PDA

View Full Version : Awards Hack


Dean C
30 Apr 2003, 19:40
I have this one user on my forums. Lets call him Bob. Now in his profile with the awards each award is listed 5 times. Now as far as i can tell from editing some people's profiles in the ACP it is only happening to this user. I just can't pick up on why this happening.

Now one thing i can confirm is that each award appears 5 times. Now if i click the one awards tick box once out of the five times it appears - when going back to the page all five tickboxes are clicked for that award. So it's definately a case of a faulty loop of some sort.

Here is the code from user.php to generate the list of awards. Can someone perhaps pinpoint any possible problems with a certain users name or if the email contains special characters or something like that...




Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



Thanks in advance :)

- Dean

filburt1
30 Apr 2003, 20:06
Useless reply but I ditched that horrible awards hack a long time ago; at WDF I simply have an admin-only-editable hidden profile field that has the actual HTML for the awards :)

Dean C
01 May 2003, 16:50
Yea but i like the ease in which i can add awards with the store hack and how there is an add-on to display who has what award etc.

I just like the way it works. See any flaws in code then buddy :)?

- miSt

GaleForce
01 May 2003, 20:20
Yesterday at 09:06 PM filburt1 said this in Post #2 (http://www.vbulletin.org/forum/showthread.php?postid=389537#post389537)
Useless reply but I ditched that horrible awards hack a long time ago; at WDF I simply have an admin-only-editable hidden profile field that has the actual HTML for the awards :)

Hey... thats a really good idea, but I like being able to hit the checkbox to add them. Needless to say though, it was a good move just adding the field, because not only can it display in the postbit, but it shows up in the profile too :)

Dean C
03 May 2003, 13:36
Ok i have not found the cause of this problem but i've made some progress. I counted the num of rows outputted by the loop. And outputted it. Now I have 5 awards and for this user the query is looping 5 times so in total it performs 25 queries :(

Now i kind of solved it in the admin cp by making a new setting in the vbulletin options which i enter how many awards there are and then add a LIMIT $numawards to the query. $numawards being the global variable. Now this solved the problem in the ACP. But in functions.php the global variable cannot be accessed - therefore i can't stop the award looping in the postbit too :(

Any ideas?

- miSt

eoc_Jason
03 May 2003, 18:40
I noticed the hack wasn't using some of the standard vB functions for accessing mysql stuff, so I fixed that, but I doubt it will correct the situation with your multiple's of 5...

I'm going to D/L the hack itself and take a look at it, I'm looking at variables that I have no clue what they mean or anything.. ;)



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------