Quick Edit! -Edit posts directly from within the thread itself

[version2]

Version2,
I wish I knew what to tell you in order to fix that but I honestly have no idea. Someone else mentioned having that problem earlier but I can't reproduce it on my own site I have no way to figure out whats causing it. I'll experiment with it some more on my test forum this weekend and try to reproduce it.. If I figure out something I'll let ya know.
Thanks, man. I will investigate it, too.

[Sh3d0w Bl3de]

I think it would be idea to do this:

Replace



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



With



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



:)

Regards,
ShadowBlade

[EvilLS1]

I think it would be idea to do this:
..............

:)

Regards,
ShadowBlade

I don't. Read the 2nd paragraph in this post (http://www.vbulletin.org/forum/showpost.php?p=577093&postcount=241) to see why I didn't include that in the hack. :)

Dewayne

[theArchitect]

I have just upgraded to 3.0.4 and it seems to have broken the hack.

When I use the Quick edit function I get this error



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------

[EvilLS1]

I have just upgraded to 3.0.4 and it seems to have broken the hack.

When I use the Quick edit function I get this error



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------




This hack doesn't add or alter any queries or database columns so I'm guessing that error is being caused by another hack. The error means that a query is attempting to update a column (editlevel) which does not exist. What other hacks have you previously installed which have something to do with editing posts?

Have you tried the regular edit to see if it gives the error?

{edit} I believe code added by the "advanced editing options" hack is causing your error:
http://www.vbulletin.org/forum/showthread.php?t=61412&highlight=editlevel

[theArchitect]

This hack doesn't add or alter any queries or database columns so I'm guessing that error is being caused by another hack. The error means that a query is attempting to update a column (editlevel) which does not exist. What other hacks have you previously installed which have something to do with editing posts?

Have you tried the regular edit to see if it gives the error?

{edit} I believe code added by the "advanced editing options" hack is causing your error:
http://www.vbulletin.org/forum/showthread.php?t=61412&highlight=editlevel
Thankyou for your assistance. I was just about to suggest that hack.

I think that I am going to have to see if Xenon can either fix it or I will have to drop it. It is very useful by I have hundreds of members who will use the quick edit hack, but only 2 Admins who would use the Advanced options.

[EvilLS1]

Thankyou for your assistance. I was just about to suggest that hack.

I think that I am going to have to see if Xenon can either fix it or I will have to drop it. It is very useful by I have hundreds of members who will use the quick edit hack, but only 2 Admins who would use the Advanced options.


No problem. I think running this query from Xenon's instructions will fix the error.

ALTER TABLE post ADD editlevel TINYINT(3) DEFAULT '0' NOT NULL;

[theArchitect]

No problem. I think running this query from Xenon's instructions will fix the error.

ALTER TABLE post ADD editlevel TINYINT(3) DEFAULT '0' NOT NULL;
Thanks for the suggestion. But I have tried that and still get the same.

[rh2004]

Can I have this so only admin's can use it... ?


Also how do I get it to work so admin can edit all posts I tried this...


<phrase 1="$bbuserinfo[username]" 2="$date" 3="$time">$vbphrase['post_edited_by_x_on_y_at_z']</phrase>


but it says


Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/username/public_html/forum/includes/adminfunctions_template.php(3055) : eval()'d code on line 41

[EvilLS1]

Can I have this so only admin's can use it... ?


Also how do I get it to work so admin can edit all posts I tried this...


<phrase 1="$bbuserinfo[username]" 2="$date" 3="$time">$vbphrase['post_edited_by_x_on_y_at_z']</phrase>


but it says


Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/username/public_html/forum/includes/adminfunctions_template.php(3055) : eval()'d code on line 41

In the code you added to includes/functions_showthread.php replace this:



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



...with this:



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------

[HaloImpulse]

alright, i did this, but i put it in different spot, and it screwed up some align ment. Im not sure why though

http://www.haloimpulse.com/forums2/showthread.php?p=5#post5

the edit button thats kinda built into the layout launches the quick edit thing, but see how it screwed up the alignment? I dont know why it did this, because the size of the image is right....

[HaloImpulse]

nevermind, i fixed.

[Matrixgl]

Doesnt work in 3.0.1 :(

I can not click on the quick reply button :(

[EvilLS1]

Doesnt work in 3.0.1 :(

I can not click on the quick reply button :(

It does work on 3.0.1 (thats what I'm using).. If its not working its probably conflicting with another hack. I know for a fact that it conflicts with the Multi-Quote hack. Do you have that one installed?

[Matrixgl]

nope, no multi quote :(

[EvilLS1]

nope, no multi quote :(

Has to be conflicting with another hack as several people (including me) have Quick Edit working with vb 3.0.1. I registered on your board to test it for myself but it appears that you've removed it.

[Deviant++]

I'm thinking of using this,


if stuff goes wrong, how long would it take to uninstall..or how difficult

any db inserts ?

[EvilLS1]

I'm thinking of using this,


if stuff goes wrong, how long would it take to uninstall..or how difficult

any db inserts ?

This hack doesn't make any changes to the db. Its very easy to install/uninstall. To uninstall simply reverse the changes you made.

[Deviant++]

yay, works

[Imperial Fritz]

Cool hack, thanks. :)

[Matrixgl]

Has to be conflicting with another hack as several people (including me) have Quick Edit working with vb 3.0.1. I registered on your board to test it for myself but it appears that you've removed it.
Yeah, just enabled it. I'd be really glad if you check it out :)

Use this url: (only this style has quick reply)
http://www.randomforum.com/forums/index.php?styleid=30

Edit:
FIxed......long ago I think I've put in the button in the style, and didnt take it off. Now the other day when I added the same button again, the second button wouldnt function but the first one would (which slipped my eyes)....now I took out the first one and the second one works just fine

Great hack, thank you very much for helping :)

[BlasterT3]

Quick edit is giving me problems

Im running vb3.0.6 fyi

Look @ the 3 steps to see my problem

http://teletran3.net/blaster/Screen_Grabs/quick_edit_step_1.gif

http://teletran3.net/blaster/Screen_Grabs/quick_edit_step_2.gif

http://teletran3.net/blaster/Screen_Grabs/quick_edit_step_3.gif

as you can see the post i edit goes up to the top and becomes a guest post. It does not do this when i do a regular edit.

thanks in advance for the help

[EvilLS1]

Quick edit is giving me problems

Im running vb3.0.6 fyi

Look @ the 3 steps to see my problem

http://teletran3.net/blaster/Screen_Grabs/quick_edit_step_1.gif

http://teletran3.net/blaster/Screen_Grabs/quick_edit_step_2.gif

http://teletran3.net/blaster/Screen_Grabs/quick_edit_step_3.gif

as you can see the post i edit goes up to the top and becomes a guest post. It does not do this when i do a regular edit.

thanks in advance for the help

Do you also have the "Advanced editing options for mods and admins" hack installed? If so, these hacks don't play nice together.. The problem you're describing sounds like this may be the case.
Someone posted a fix in the other hack thread but I dunno if it works or not b/c I don't use that hack. Here's the link:
http://www.vbulletin.org/forum/showpost.php?p=530448&postcount=110

If you're not using that hack then something may have changed in 3.0.6 and Quick Edit may no longer be compatible.

Does anyone else have this working on 3.0.6?

[BlasterT3]

Do you also have the "Advanced editing options for mods and admins" hack installed? If so, these hacks don't play nice together.. The problem you're describing sounds like this may be the case.
Someone posted a fix in the other hack thread but I dunno if it works or not b/c I don't use that hack. Here's the link:
http://www.vbulletin.org/forum/showpost.php?p=530448&postcount=110

If you're not using that hack then something may have changed in 3.0.6 and Quick Edit may no longer be compatible.

Does anyone else have this working on 3.0.6?

thankyou VERY much. this hack now works on vb 3.0.6.

as for 3.0.6. the functions_showthread.php mod is a little different then the instructions say but its easy to figure out

[EvilLS1]

thankyou VERY much. this hack now works on vb 3.0.6.


Thanks for verifying that it works on 3.0.6. :)

[EvilLS1]

as for 3.0.6. the functions_showthread.php mod is a little different then the instructions say but its easy to figure out

Thanks for letting me know. I updated the instructions so that its easy to find. :)

[BaconDelight]

Hi. first, after reading through all of this, great work by EviLS1 and everyone else on keeping this thing up to date!

I'm planning on installing this hack on my test board tonight (after upgrading to 3.0.6 which I haven't gotten around to doing even though my live board has been). My question is, what is and what isn't in the updated instructions available in the original post? There have been so many tweaks through this thread that I got lost. If I followed correctly, if I follow the instructions as written, I shouldn't run into any known issues (at least ones that were known and have been resolved), and the only features missing will be the delete option and the ability for Admins/Mods to quick edit everyone's post (which I don't want anyway), right? What about the signature check box? Has that been fully updated in the instructions.

Basically I'm asking, should following the instructions get the hack working without having to comb through the thread finding little fixes here and there?

[BlasterT3]

Hi. first, after reading through all of this, great work by EviLS1 and everyone else on keeping this thing up to date!

I'm planning on installing this hack on my test board tonight (after upgrading to 3.0.6 which I haven't gotten around to doing even though my live board has been). My question is, what is and what isn't in the updated instructions available in the original post? There have been so many tweaks through this thread that I got lost. If I followed correctly, if I follow the instructions as written, I shouldn't run into any known issues (at least ones that were known and have been resolved), and the only features missing will be the delete option and the ability for Admins/Mods to quick edit everyone's post (which I don't want anyway), right? What about the signature check box? Has that been fully updated in the instructions.

Basically I'm asking, should following the instructions get the hack working without having to comb through the thread finding little fixes here and there?


everything has been updated for vb 3.0.6 as stated in the post above yours. this should go flawless for you

[catocom2]

yep I just re-installed it on 3.0.6, and it works great, even with the multiquote hack.
I think there is a little bit of code change where it say to look, but you should be able
to figure it out.

[BaconDelight]

Thanks! Installed and working. Just want to note, the code that you point to to find for the "Reason for editing" add-on appears to have changed from using <td> to <div>, and the dimensions have changed. So it took a little to find that bit of code. It's in post #30 if you care to update it.

[BaconDelight]

Need some help here, a user found a possible bug...

The user is running Opera. In a thread in which he's already posted, if he attempts to submit a new post via the quick reply box, using the option-s shortcut to submit it, the new post does not show up, and instead, the most recent post he'd made in the thread gets the "Last edited by... tacked onto it. This only happend when he uses the option-s shortcut to submit, it works fine if he clicks the "Post Quick Reply" button. And this does not happen on IE using the Alt-s shortcut. So only on Safari, only with quick reply, and only with the option-s shortcut to submit.

Quick edit is the only hack I have installed that involves posting or editing, so it's highly likely that it's the culprit.

[BaconDelight]

OKay, I've figured out what's happening, but I don't know how to fix it.

First, a corretion, it slaps the "Last edited by.." on the user's FIRST post in the thread, not the last.

Now, for what's happening. All it is is that Opera is sending the ctrl-s command to the hidden quick edit window instead of the main active window. Sine that window also has a submit button with the same keyboard shortcut, it submits the unaltered hidden edit box instead of the quick reply box.

This does not happen on Windows IE, or Firefox on Mac.

Okay, so now that I've figured out what the problem is, I have no idea if it can be fixed. Any way the code can be altered to make sure that Opera has the focus on the right window?

[BlasterT3]

do you have a link to your forum and post?

[EvilLS1]

BaconDelight,
As noted in the first post Quick Edit does not work with opera and the code isn't even displayed in that browser. Check the code in the postbit template and you should find "!is_browser('opera')" in the conditional which determines whether or not the quick edit code is to be displayed. If you don't see it, that means you're either using an old version of quick edit or you're using someone elses add on version.

Try submitting a quick reply in opera with ALT + S here at vb.org and you'll see that it doesn't submit here either.. Quick Edit isn't installed here.

[BaconDelight]

Sorry, my mistake, I meant Safari, not Opera.

Quick eidt works, quick post works. But when you try to submit a quick post with ctrl-s in Safar, it sends the ctrl-s to the hidden quick edit window.

[EvilLS1]

In that case, try this:

In the showthread_quickedit template find

name="vbulletinform"

and change the form name to something else (vbform will do). I'm not familiar with the safari browser but I think that will fix it.

[EvilLS1]

If that doesn't work try changing the accesskey in this code to something else:



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



I dunno if that will work or not but its worth a try.

[BaconDelight]

Alright, so changing the access key sort of helps. Ctrl-s is now working, but now using the new access key for submitting a quick edit is doing something similar to the orignal issue. Namely, if the user has more than one post on the page that's displayed, using the new access key will not necessarily submit the correct quick edit window, it submits it to one of the other hidden quick edit windows on the page. The user that's having this problem also mentioned that clicking the "preview changes" in a quick edit window submitted it instead of going to the preview page. Again, these issues are only present with Safari, on Mac OSX. Anyone with experience with Safari have any ideas?

[BaconDelight]

Forgot to mention, I changed the form name as suggested in post #286 above and that didn't do anything.

[yoyoyoyo]

installed in 10 minutes and works great with no hitches in IE or safari

[MAK-upl]

works with 3,0,6 - good job - clicks install

[swantonio]

install ottimo 3.0.6 :squareeyed:

[Imperial Fritz]

seems to work fine with 3.0.7

[MichaelJM13k]

Hey,
I'm a newb to vB and installing hacks so if someone could please help me out i would be very greatfull!

On one of the last parts when it says:

"##### In your postbit & postbit_legacy templates find:"

Where do i find those templates?
Also where it says:"

How do i make a new template?

Thanks,
MichaelJM

[EvilLS1]

Hey,
I'm a newb to vB and installing hacks so if someone could please help me out i would be very greatfull!

On one of the last parts when it says:

"##### In your postbit & postbit_legacy templates find:"

Where do i find those templates?
Also where it says:"

How do i make a new template?

Thanks,
MichaelJM

Look in your admincp under Styles & Templates.

[zetetic]

I've had this working for a long time, but since upgrading to 3.0.6 using quick edit on a post removes my subscription. Any ideas?

[TCM]

I love it, and so do my users. Thanks. :)

[zetetic]

I've had this working for a long time, but since upgrading to 3.0.6 using quick edit on a post removes my subscription. Any ideas?
Anyone...? Anyone...?

Here's my showthread_quickedit template:

(As you can see I've added a selection box at the bottom--shown commented out here--to temporarily solve this problem, but I'd rather not have to use that if possible.)



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------

[zetetic]

Well in case anyone else wants to solve this problem, Google led me to an answer someone posted at the Tivo forums.

Edit editpost.php and add the red lines (two on top, close bracket on bottom):



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



Then edit the showthread_quickedit template and change emailupdate=9999 to emailupdate=9998

This will prevent quickedit from messing with the users subscription.

[TCM]

Great hack, but I don't like any of the existing icons, so here's the one I made.

For the default and vB_Greenish skin that we use.

[Kirk Y]

Hey, first off, I love this hack it's great! My question is what would I need to do to enable this hack for all members to be only able to edit their posts and at the same time give administrators the ability to edit everyones post. Any help would be much appreciated!

-acidburn0520

[zetetic]

Hey, first off, I love this hack it's great! My question is what would I need to do to enable this hack for all members to be only able to edit their posts and at the same time give administrators the ability to edit everyones post. Any help would be much appreciated!

-acidburn0520
Check this post (http://www.vbulletin.org/forum/showpost.php?p=591269&postcount=260) out. I think that makes it so only admin can edit posts, but if you combine the way it is with what it says there you can probably make it so both the poster and the admin can edit.

[DavidN]

Consider it installed :D

I've seen this run beautifully at www.ocforums.com, so its time to give it a whirl myself ... ;)

[Titanium878]

Aye, DavidN and I are installing it on our forums very soon it looks to great to pass up :D

[JohnBee]

I have installed this and the only complaint I have is that the QE window
opens up downwards and outwards left so the window is always off the
screen.

Otherwise its a nice feature

[Ghostsuit]

hmm anyone found that after using quick edit it unsubscribes you from the thread?

[zetetic]

hmm anyone found that after using quick edit it unsubscribes you from the thread?
Yep. I posted a solution on the last page (http://www.vbulletin.org/forum/showpost.php?p=638660&postcount=299). :)

[Snitz]

I just have one question to ask and I know it's not to hard to answer
there is an edit button in the thread which will take you to the full edit page
well I was wondering if you can make that button open the dhtml edit page and add a link saying "go advanced" which will take you to the full edit page!

I just wanna know how to add the button!

[Snitz]

I managed to add the "Go Advanced" button, but when u click on it, it doesn't take you to the full edit page, it just reloads the current one :confused:
what I did is the following:

in showthread_quickedit find


Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------


add after


Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



find


Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------


add after


Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



have I done anything wrong ? :\

[mholtum]

/me isntalls. Great mod!

[Snitz]

I thought this hack will allow also the mods and admins to use it on all the posts, but I was wrong.....
anyway update it to make it work for mods and admins ?

[zetetic]

I thought this hack will allow also the mods and admins to use it on all the posts, but I was wrong.....
anyway update it to make it work for mods and admins ?
All your answers can be found in this thread, Snitz. But if you don't want to read it...

I have it configured so that mods and admins can edit all posts, and with a 'preview' button that opens the advanced editor. I also fixed the subscription bug.

Here's what I have in functions_showthread.php


Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



And my showthread_quickedit template:



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



You might have to tweak it some for your style... can't remember if I did. :)

[Crapaddict]

All your answers can be found in this thread, Snitz. But if you don't want to read it...

I have it configured so that mods and admins can edit all posts, and with a 'preview' button that opens the advanced editor. I also fixed the subscription bug.

Here's what I have in functions_showthread.php

[...]

You might have to tweak it some for your style... can't remember if I did. :)
Cool, I wanted something like this too :D

[fordkiller]

im haveing this problem with the hack i am running vb 3.0.3 and i keep getting this error every time i try ti install the code in the templates ok any help that would be great thanks again

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_IF in public_html/Forums/includes/adminfunctions_template.php(3055) : eval()'d code on line 176

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

and if i click on continue then the posts go away and you cant even see the posts and a block comes across the top of the tread page above the header ??

[ben_erhan]

it is a marvelleous hack.thanks friend.

[Strike3ForumsMH]

I thought I followed the instructions perfectly. I have received no errors with anything that I can see but the quick edit button is not appearing. And the button is titled and located in the correct area.

Anyone have any idea of what I need to do?

Sorry for the lack of details but that's all I got.

Edit: To avoid confusion I have tested it on both IE and Firefox browsers.

[Borimikan]

Can we have the posibility to be able the quick edit button not just in our own post and also have it in other users post,

(knowing that we are administrators of the forum) NOT REALLY IMPORTANT BUT I FELT TO TELL IT SO...

[Xplorer4x4]

Briliant hack EvilLS1. Your original hack is working just fine in vB3.0.8. :)

However I used the edit in Post 103 (http://www.vbulletin.org/forum/showpost.php?p=499205&postcount=103) so that moderator and admins can use it. None of my users/staff have complained of any problems except for one. He has tried both IE and fireFox.

Here are two screen shoots in one. The top shot is the error that he gets when he is at the index. The one below is the error he gets when viewing a thread.
http://img107.imageshack.us/img107/3644/xp13bf.th.jpg (http://img107.imageshack.us/my.php?image=xp13bf.jpg)
Any ideas on how i might be able to fix that?
Thanks.

[yoyoyoyo]

None of the code in this file is mine. I simply added all of the fixes that this thread has in it for quick reference, and I decided to zip it up and post it here to make it easier for folks. I also added the "reason for editing" option mentioned in this thread as well.

Thanks to everyone for all of the fixes/help, and thanks to EvilLS1 for making such a great hack!

As I said, none of the work is mine, I just compiled it to make it easier for me to follow, so I didn't have to install it, and then go through all of the fixes mentioned in this thread. Instead I just read the thread, and updated the install info, and it works fine in vb 3.0.8 for me.

[slim cutty]

Why as an Admin when I quick edit my posts... the post shows that I posted as a guest? It works for all other users except me?..lol

If I started a thread and quick edit it I become a guest (my post shows me as guest), when I leave the post it will dissappear

can someone help?

thanks