Message Editing Hierarchy

[Xenon]

Have you ever noticed that Admins and Super Moderators can edit/delete/peak everyone's messages in your forum? This also applies to Moderators for the board they are assigned.

Normally this shouldn't be a problem, but on bigger sites with a lot of Mod's it could lead to problems sometimes.
This is a Plugin version of my vb3.0 hack i released here,

After applying the hack default editing permissions in your board will be changed like this:

Moderators: Can edit everyone's posts in the forum they're assigned, UNLESS author is another Moderator, SuperMod or Admin.
SuperModerators: Can edit everyone's post in all boards UNLESS author is another SuperMod or Admin.
Admins: Can edit eveyone's post in all boards UNLESS user is another Admin
SuperAdmins: Can edit eveyone's post in all boards (Superadmins are defined in config.php)

So the hack will apply a "message editing hierarchy" in your board and everyone will be able to edit messages for ones who are below him and cant touch messages of his superiors..If they try, they'll get no permission page. This will apply for editing the messages, deleting the message via edit message or just peaking inside it. But be warned: messages can still be deleted via "Delete Thread / Posts" menu..

If you install this plugin, please click install, thank you..

Enjoy!
Xenon

[Link14716]

Does this affect the quick edit? ;)

[Xenon]

it prevents quick edit, but results in a bug it seems,

i have to look at it a bit more :)

[Chris M]

Installed and working somewhat ;)

The quick edit thing doesn't but you've already mentioned that so I'll wait for the update:p

Satan

[Gary King]

Would like to have it working with quick edit still intact as well :)

[Xenon]

I'll do my best.

it was a testhack for me, not planned to be released already, but the developers where to fast to release the beta to the public ;)

[Xenon]

Ok, i've uploaded a newer version.

AJAX editing will just result in a no change version, but no JS error should appear anymore.

preventing the editbutton or ajax at all, isn't that easy, right now, i just see a way which would mean a lot of queries additionally to showthread, so i won't do so ;)

[mholtum]

/me installs!

Thanks

[ehjay]

Xenon, the early version of this hack on my 3.0.7 board struggles when a user has an additional usergroup. It seems as though the hack works properly, but any moderator or super moderator that is also a secondary member of another usergroup has the ability to edit/etc admin & super-admin posts.

Is there a way to perhaps prevent this?

Note: I put it here and not in the old hack's thread, since I assume it still applies.

[Xenon]

my hack doesn't look at primary or secondary usergroups, it uses the built in permission functions by vb, so noone should be able to edit super admin posts if he isn't a superadmin himself.

if someone can, you have added it to the super admin users in config.php or the permission system has a bug.

[ehjay]

Alright, think I tracked it down to a bug generated in the permission system.

[Link14716]

Xenon: Concerning the super admin check, why are you using preg_split when you could just

Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------

?

[Xenon]

actually i use exactly the codeline which is used in admincp/adminpermissions.php so you better ask the vb devs why they used that way :)

[FD929]

Hey Stefan, since they eliminated the double click ajax issue, will this be made to work?

[Johannes de León]

It would also be nice to have the Advanced Editing Options. :)

[Xenon]

@JdL: hehe, maybe once upon a time ;)

@FD: have you tried it?
didn't have time to look at beta 3 right now

[FD929]

Yeah it's never worked for me. b2 or b3, love the idea though. This would be a great addition.

[Xenon]

i'll look at it when i have time.

as it's a plugin, it should work normally....

[FD929]

Hi Stefan, any luck with this?

[Xenon]

sorry, i will be able to work on that after the vb.org upgrade

[utw-Mephisto]

Is this now actually working for RC2 too ?

[Noonster]

Is this fully working for Gold version yet?

Cheers
Darren

[Xenon]

no idea, i was on holidays, so don't have installed gold yet, but i don't think it doesn't work

but it's just a plugin so, just test it, and if it doesn'T work as you like it, you can always deactivate it without any risk :)

[VBUsers]

i installed it but there are bugs.

1) my co admins can go into the edit field and see the post but when they edit and save it doesnt post the typed info. it does the job by not allowing but theres no error message popping up. im on 3.5.1 .

and also i have added a custom co admin usergroup how do i make them follow the same hierarchy or does it do it automatically.

[Xenon]

about the second: that's done automatically.
the hack is based on permissions, not on usergroups, so if they have access to the acp they're counted as admins

as for 1, that may be due to the new functionality, this hack was written for Beta 1, but the edit system has totally changed regarding that DAMN Ajax

[VBUsers]

ok thanks sounds good. i guess ill wait for the 3.5.1 upgrade.

[DocBenny]

Ok how do I install this into my forum... Nothing happens when I click install..haha

Do I do it through admin cp or what?

[Xenon]

yep

please refer to vbulletin manual to find out how to install plugins!

[DocBenny]

I uploaded it.. I was able to edit a message of another super-admin account

I'm not sure if it's working right.. I'm a super-admin, should I be able to edit another super-admin?

[DocBenny]

Ok tested it with a temp admin.. It works..but it's weird in a way; there's no error page displayed, instead you think you're actually editing the message, but once you click on save...that post you were editing becomes just plain text in white background with no postbit. This fixes itself once you hit refresh page.. And you see that nothing has been done to that post.

I would have preferred an error page or something.. that whitebackgroungd with just text without poster information right after clicking save scared me a bit.

[Psionic Vision]

Do you mind if I integrate this hack into my port of your Adv. Editing Options? :P So that it be a 2-in-1 :)

[Xenon]

yep, because they are different hacks, and should stay so.

i would ahve merged the two vb3 versions already if i would feel they would belong together ;)

[Mikecp421]

had it on 3.0.8 thanks again!

[Bison]

Do anyone have this working with 3.53?

[Mikecp421]

yes I do and it works fine!

[Luggruff]

Thanks ! Works great, only you don't really have a clue what's going on when trying to edit a post you don't have permission for, as it looks like some sort of "bug" when trying to edit someones post.. since you only get the text of the post, and in "quickedit".. when you hit save, you get the post, only with no background o_0

[DocBenny]

It's not working with 3.5.3 for me.. it was working with 3.0 hmmm

[DocBenny]

Mods cannot delete the messages but SuperMods can delete the messages of Admins. Something is not working as it should.

[Bison]

Mods cannot delete the messages but SuperMods can delete the messages of Admins. Something is not working as it should.

Because it's not working for you ... and the same here. Right after importing the plugin, I cannot see where the actual plugin is listed.

[DocBenny]

for me it's listed.. under plugin manager.

[Xenon]

actually the plugin was made for 3.5.0 Beta 1.

there was no ajax during that time, so remember that when you imort it ;)

[ehjay]

Any plans to rework this for the newer versions of 3.5.x, Xenon?

[Xenon]

plans yes, but right now, it's not on toop of my to do list, there are more important things these days :)

[Pickalo]

How can I add a group that can over ride everyone (including admins)?

-been a fan of your hacks since back in the days of 2.8 Xenon, thanks.

[Xenon]

nice to hear :)

well that's an easy task.
the group has to be able to edit posts at all (so it should be a supermod group) and then just change that line from the plugin:



Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------



into


Code:
---------------
Code is only visible to licensed users, and only when logged into the forums.
---------------

[Pickalo]

Thanks for the help mate :)

[trinigamers]

vb 3.5.4?

[WebsiteDonation]

Smart organization ! First 5 stars rated & Install clicked ;)

[brvheart]

3.6.1 I hope please :)

[brvheart]

Xenon....will this work on 3.6.x versions? If not any plan to port it?

[Xenon]

Hmm, no idea, haven't tested it on vb3.6 and i am completely out of vb these days so no plan to port it right now

[Mikecp421]

awesome hack, hope you can or someone can

[brvheart]

I pmed Xeon and as long as we mention him as origial author and give him credit, he has no problem if we update this...I am still learning to code etc but if anyone wants to give me a hand with this it would be a great edition for 3.6.x...has anyone tried this on 3.6.x to see if it will work in it's current state?

[Mikecp421]

I have used this and like it but it doesn't work on 3.6.3

[brvheart]

anyone want to port this? I would just not sure how to do it yet...

[brvheart]

I just installed on 3.6.4 and it seems to work ok except it does not refresh when editing if you dont have permission to edit the post...


what did it NOT do when you installed it Mikecp421?

[frank44]

Has anyone been able to update this mod yet? :)

[DocBenny]

We need this hack for the 3.6.x versions please. :)

[David Lama]

We need this hack for the 3.6.x versions please. :)

3.7 please :)

[G0F0RBR0KE]

I tried this for 3.5.4 and it works perfect =]