[The Realist]

Trigunflame is a gent and solved my problem

HOTM I say
Laters

[The Realist]

Another problem.

Clicked edit and my page is twice its size?

Not my day?

[Trigunflame]

Originally Posted by The Realist

Another problem.

Clicked edit and my page is twice its size?

Not my day?

Screenshot , and again Im not getting this problem on my test forums.

[buro9]

Had a nice problem relating to the footer template and the inline javascript.

It compressed to:
<script type="text/javascript"><!-- // There was a vbulletin comment here vBulletin_init(); // Initialize 'Active' Table Cells //activecells_init();//--></script>

The problem with that is that // is a line comment, and then there is no line break, so the whole javascript is commented out, and menu's do not get initialised, etc.

The result is that those swishy JavaScript drop down menus break.

You can fix this by updating your footer template to just have:
<script type="text/javascript">vBulletin_init();/script>

In place of the larger block. That does it for me

Aside from that minor problem, this hack is wonderful.

I'm going to go off and search for other places that might be impacted by this though... recommendation: Don't compress JavaScript at all... leave line breaks in.

[Trigunflame]

Originally Posted by buro9

Had a nice problem relating to the footer template and the inline javascript.

It compressed to:
<script type="text/javascript"><!-- // There was a vbulletin comment here vBulletin_init(); // Initialize 'Active' Table Cells //activecells_init();//--></script>

The problem with that is that // is a line comment, and then there is no line break, so the whole javascript is commented out, and menu's do not get initialised, etc.

The result is that those swishy JavaScript drop down menus break.

You can fix this by updating your footer template to just have:
<script type="text/javascript">vBulletin_init();/script>

In place of the larger block. That does it for me

Aside from that minor problem, this hack is wonderful.

I'm going to go off and search for other places that might be impacted by this though... recommendation: Don't compress JavaScript at all... leave line breaks in.

Buro, did you try the new version? Mutli-Line javascript is left in its standard format short of tabs.

ie. using the updated version, my footer looks like this (Compressed Template):

http://narutotalk.org

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

[buro9]

Nope, everything else is working fine... editors doing their job, popups where needed are working (attachments, i have a translate hack, buddy list, thread replies, etc).

So just that one very small adjustment... and frankly, for the benefit this hack gives I'd opt for the editing of the footer template over reducing the compression the hack does.

[buro9]

Originally Posted by Trigunflame

Buro, did you try the new version? Mutli-Line javascript is left in its standard format short of tabs.

Hehe, maybe not

I'll upgrade now

[buro9]

It works, but I had to add a line break.

I'm not sure what version of footer I customised (most likely the vb3 beta one that I've been dragging through each update), but it had the <script block directly following the DST correction block:

</if><script

For some reason that I don't want to look into , it would not recognise that as a JS block and was compressing it.

If I moved the <script onto a new line like thus:
</if>
<script

Then it worked perfectly.

As I said though... the footer template is one I modified in vb a long time ago... so this is likely not an issue as viewing the original now shows that they are indeed on new lines already and thus work perfectly.

If anyone has old templates that they've modified though, they hopefully will read this and add the linebreak

[boeserwolf]

Hi


And here is the german translation for all german users:

[Trigunflame]

Update:

Removed support for inline javascript, all javascript stays line-per-line.
Removed support for inline styles, all style data stays line-per-line.

[boeserwolf]

Would you please tell me what to change in the code, so that I can change it in the translation too?

[Rambo]

Hrm,

Here's a little problem with the latest version.

[Trigunflame]

Originally Posted by Rambo

Hrm,

Here's a little problem with the latest version.

Ok, will try and contact; someone else is having same problem.

[Trigunflame]

Update:

Im workin on the solution, ive identied the problem as a special template.

[Trigunflame]

Update;

Finished, everyone use the newest version of the code.

Problem was a certain template that delt with fonts available from drop down menu, they were being compressed also, causing errors.