PDA

View Full Version : Last Post Title in Forumhome & Forumdisplay


bbqfan
20 Sep 2001, 09:18
Vision 2.1

i promised to reduse the extra queries to 1. in this 1 query, we can get the last post title, last thread title and last icon... so it have a shorter load time...

i still believe my this hack Release is the simplest mode to display the last post titles in Forumhome & Forumdisplay Page, because it dosen't need any action in database, and just modify 2 places in 2 files... furthermore, now the new vision have reduced the load time very much...

many thanks to PPN for his help...

OK, let's go!

1. change index.php and forumdisplay.php:

find in index.php:
// prepare template vars
if (!$showforumdescription) {
$forum['description']='';
}

find in forumdisplay.php:
// dates
if ($forum['lastpost']>0) {
$forum['lastpostdate']=vbdate($dateformat,$forum['lastpost']);
$forum['lastposttime']=vbdate($timeformat,$forum['lastpost']);

below these add:
// start last post title hack by cx
$lasttitle = '';
$lasticon = '';
if ($forumperms['canview']) {
$forum_this = $DB_site->query_first("SELECT post.title AS posttitle,thread.title AS threadtitle,post.iconid,icon.title AS icontitle,iconpath FROM thread LEFT JOIN post USING (threadid) LEFT JOIN icon USING (iconid) WHERE post.username='$forum[lastposter]' AND post.dateline=$forum[lastpost]");

$lasttitle = $forum_this[posttitle];
if ($lasttitle == '') {
$lasttitle = 'Re: '.$forum_this[threadtitle];
}
$lasttitle_raw = $lasttitle;

if (strlen($lasttitle) > 30) {
$lasttitle = substr($lasttitle, 0, 28);
$lasttitle .= '..';
}

if ($forum_this[iconid] > 0) {
$lasticon = "<img src=$forum_this[iconpath] alt=\"$forum_this[icontitle]\" align=absbottom>";
}
}
// end last post title hack by cx



2. i have made the post icons display... so change the template forumhome_lastpostby to:


<table cellpadding="0" cellspacing="0" border="0" width="100%" id="ltlink"><tr align="right">
<td nowrap><smallfont>$lasticon <a href="showthread.php?s=$session[sessionhash]&goto=lastpost&forumid=$forum[forumid]" title="Go to last post: $lasttitle_row">$lasttitle</a><br>
by <a href="member.php?s=$session[sessionhash]&action=getinfo&find=lastposter&forumid=$forum[forumid]">$forum[lastposter]</a> @ $forum[lastpostdate] <font color="#666686">$forum[lastposttime]</font>
</smallfont></td>
<td nowrap> <a href="showthread.php?s=$session[sessionhash]&goto=lastpost&forumid=$forum[forumid]"><img src="images/lastpost.gif" border="0" alt="Go to last post: $lasttitle_raw"></a></td>
</tr></table>

DONE!




------------------------------------------------------------------------------
The Older Vision
a PHP+MySQL newbie's bad exercise...
if you find interest in this you can compare it with the last Release...


someone has posted this type hack, but this Release has a little difference. and in the other's release there's some bugs(about the subforums' last post title), now it has been fixed:

1. change index.php and forumdisplay.php:

find in index.php:

// prepare template vars
if (!$showforumdescription) {
$forum['description']='';
}


find in forumdisplay.php:

// dates
if ($forum['lastpost']>0) {
$forum['lastpostdate']=vbdate($dateformat,$forum['lastpost']);
$forum['lastposttime']=vbdate($timeformat,$forum['lastpost']);


below these add:

// start last post title hack by cx
$forum_this = $DB_site->query_first("SELECT parentlist FROM forum WHERE forumid=$forum[forumid]");
$forum_this_parents = explode(',', $forum_this[parentlist]);
$forum_this_parents_count = count($forum_this_parents);

$forum_sons = $DB_site->query('SELECT parentlist,forumid FROM forum');
while ($forum_son = $DB_site->fetch_array($forum_sons)) {
$forum_parentlist = $forum_son[parentlist];
$forum_parents = explode(',', $forum_parentlist);
$forum_parents_count = count($forum_parents);
if ($forum_parents[$forum_parents_count - $forum_this_parents_count] == $forum[forumid]) {
$forum_son_all[] = $forum_son[forumid];
}
}

if ($forum_son_all != '') {
$forum_sons = implode(',', $forum_son_all);

$lastposttitlex = $DB_site->query_first("SELECT post.title FROM thread,post WHERE thread.forumid IN($forum_sons) AND post.threadid=thread.threadid AND post.visible=1 ORDER BY post.dateline DESC");
$lastposttitle = ''.$lastposttitlex[title];

if ($lastposttitle == '') {
$lastposttitlex = $DB_site->query_first("SELECT title FROM thread WHERE forumid IN($forum_sons) AND visible=1 ORDER BY lastpost DESC");
$lastposttitle = 'RE: '.$lastposttitlex[title];
}

if (strlen($lastposttitle) > 30) {
$lastposttitle = substr($lastposttitle, 0, 28);
$lastposttitle .= '..';
}
}
// end last post title hack by cx


2. change the template forumhome_lastpostby to:

<div align=right><smallfontbr><nobr><a href="showthread.php?s=$session[sessionhash]&goto=lastpost&forumid=$forum[forumid]" title="turn to last new post">$lastposttitle</a></nobr><br><nobr>$forum[lastpostdate] <font color="#666686">$forum[lastposttime]</font></nobr><br><nobr>by <a href="member.php?s=$session[sessionhash]&action=getinfo&find=lastposter&forumid=$forum[forumid]">$forum[lastposter]</a></nobr></smallfont></div>


3. done! easy and funny job :)

Sinecure
20 Sep 2001, 09:23
Is there an example/preview we can see?? Perhaps a URL??

Goldfinger
20 Sep 2001, 09:56
yes an example would be nice before i add it to my hack list :).

Delhaze
20 Sep 2001, 13:11
Nice work, i've been waiting for someone to fix the subforum bug, but wasn't sure if anyone would figure out the parent/child stuff.

This doesn't include the icon that the old hack now inlcudes, any chance you (or someone) can add it please ?

Scott MacVicar
20 Sep 2001, 17:44
This increased loading time on the forum by over 7 seconds. This is far too long, so i removed the hack.

h4p3
20 Sep 2001, 17:47
Originally posted by PPN
This increased loading time on the forum by over 7 seconds. This is far too long, so i removed the hack.

Right, installed it on my main board, 40 user online -> server load 11 *lol*

Scott MacVicar
20 Sep 2001, 18:06
I'll post the version i was using before i tried to install this one, i wrote it so when someone posted it added the title to the forum table. Then it is selected anyway when the forum is loading. I never managed to get it compatible with sub-forums, i will work on that just now.

Goldfinger
21 Sep 2001, 04:33
well obviously it adds loading time he queried the database 4 times in this script.. way to many times. try another way.

Scott MacVicar
21 Sep 2001, 09:06
64 users on board was 0.48
after this hack it hit 9.46

and that was with 39 forums :rolleyes:

i just have to finish testing my versio and hopefully it should work well.

bbqfan
23 Sep 2001, 11:49
yes i have chage my code in the first post. or you can see the screenshot here...

Scott MacVicar
23 Sep 2001, 12:14
you don't need
$permissions_this = getpermissions($forum['forumid']);

this is already called eariler in the function in the form

just use $forumperms['canview']

so
if ($permissions_this['canview']) {
becomes
if ($forumperms['canview']) {

this hack also runs 3 extra queries per forum, so if you have a large board with say 40 users online and 50 forums. Then thats 6000 extra queries, they would usually only have to run 2000 to get forum info. This will have a large impact on server load.

bbqfan
23 Sep 2001, 12:29
Originally posted by PPN
you don't need
$permissions_this = getpermissions($forum['forumid']);

this is already called eariler in the function in the form

just use $forumperms['canview']

so
if ($permissions_this['canview']) {
becomes
if ($forumperms['canview']) {

this hack also runs 3 extra queries per forum, so if you have a large board with say 40 users online and 50 forums. Then thats 6000 extra queries, they would usually only have to run 2000 to get forum info. This will have a large impact on server load.

yes, u r right...
i have seen your hack and i think it's great.
but i don't like to modify my database...

maybe i can reduce the 3 extra queries to 1...:)

my hack is just for another choice...

bbqfan
23 Sep 2001, 16:12
OK the last update codes have been added in the first post.
this will be the final vision----i hope:):)

now just 1 query for 1 forum...

Freddie Bingham
23 Sep 2001, 16:47
bbqfan please enter your license information into your profile.

davibou
26 Sep 2001, 13:52
hello i'm french so excuse me for my bad english!!

I found a bug in your hack


When you repply to a tread if you dont use icon for the repply
nothing appear for the title just Re:

Can you update the hack or found the bug please ??

Or if there is no bug tell me please


This hack is great ....

bbqfan
27 Sep 2001, 02:13
to freddie: sorry i work for my boss and the license belongs to him... maybe next time i can ask him for this...


Originally posted by davibou
hello i'm french so excuse me for my bad english!!

I found a bug in your hack


When you repply to a tread if you dont use icon for the repply
nothing appear for the title just Re:

Can you update the hack or found the bug please ??

Or if there is no bug tell me please


This hack is great ....

to davibou: u r welcome. i m so happy because someone like my hack. and there is 1 bug actually. i have updated the code in the first post:)

shadowbreed
28 Sep 2001, 20:27
Great hack


Thought i had a bug my mistake

dwh
14 Aug 2002, 20:23
I think you have a typo:
$lasttitle_row
should be
$lasttitle_raw?

dwh
14 Aug 2002, 20:39
Does this hack work for anyone? I get a blank display?

sonic3d
05 May 2003, 23:13
does ne1 know how to make it when the last post in the subforum of the parent forum to sumthin?

l8er
sonic