PDA

View Full Version : Miscellaneous Hacks - IE11 browser detection and fixes


Zachery
17 Oct 2013, 17:37
IE11 has some issues with vB5 as it stands now due to bad browser detection. These changes should address the issues at hand until the software is patched.

In core/includes/functions.php find:





// detect macintosh



Add above:



// Detect Modern IE11+

if (strpos($useragent, 'trident') !== false AND !$is['opera'] AND !$is['ie'])

{

preg_match('#rv:([0-9\.-]+)#', $useragent, $regs);

$is['ie'] = $regs[1];



}





Next, find:



if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror'])



And replace it with



if (strpos($useragent, 'gecko') !== false AND !$is['safari'] AND !$is['konqueror'] AND !$is['ie'])


Next, we have one more change to make:

In /includes/vb5/frontend/controller.php Find


if (isset($_SERVER['HTTP_USER_AGENT']) &&
(strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false))
{
header('Content-type: text/plain; charset=UTF-8');
}

Add after


// IE11+ detection, MS changed the UA
elseif (isset($_SERVER['HTTP_USER_AGENT']) &&
(strpos($_SERVER['HTTP_USER_AGENT'], 'Trident') !== false))
{

header('Content-type: text/plain; charset=UTF-8');
}

Afrika
13 Nov 2013, 15:21
Done, but in opera it does'nt work

Zachery
13 Nov 2013, 17:15
It wasn't intended to fix opera, but I might be able to spare some time to look into it.

Afrika
16 Nov 2013, 22:29
great :D Thanks

Zachery
20 Nov 2013, 19:27
Made a small change to fix a IE10 detection issue.

IggyP
28 Nov 2013, 09:36
thanks for posting zachery:)

one note tho the first file is rather large so for reference its looking 3/4 down or so line 7200something or such i forget exact but in that area