Register Members List Search Today's Posts Mark Forums Read

Reply
 
Mod Options
Patched Flash Uploader to Fix Known Exploits Details »
Patched Flash Uploader to Fix Known Exploits
Mod Version: 2.00, by alexm (Coder) alexm is offline
Developer Last Online: Apr 2019 I like it Show Printable Version Email this Page

vB Version: 4.x.x Rating: (33 votes - 4.88 average) Installs: 203
Released: 14 Jan 2014 Last Update: Never Downloads: 840
Supported Code Changes Additional Files  

UPDATE Dec 2014: 4.2.2 PL2, 4.2.2 PL3 and 4.2.3 core download packages from vBulletin now include this patched version of uploader.swf as standard.

This is a patched version of YUI 2.9.0 uploader.swf as used by vBulletin 4.x for managing multiple file uploads.

An exploit was found in the flash uploader (uploader.swf) file supplied with vBulletin 4.x. This file is part of the Yahoo YUI 2 Library which is end of life and Yahoo have stated that they will not be fixing it. Yahoo recommends that the file is removed as the flash uploader has been deprecated.

vBulletin's recommended fix is to replace the file with an empty file of the same name. If you do this, however, and rely solely on the Ajax uploader you will not be able to select multiple files without further modifications.

This modification is a recompiled version of uploader.swf with the above exploit fixed. An additional potential exploit has also been fixed by disabling a parameter not used by vBulletin.

The YUI source used is provided freely by Yahoo to whom I give full credit.


1) Installation

a) Extract uploader.swf from the .zip file and replace your existing file here:

<forum_root>/clientscript/yui/uploader/assets/uploader.swf

b) Make sure the flash uploader is enabled in the Admin Control Panel

Options -> Message Attachment Options -> Asset Manager - Enable -> Select "Yes, Flash Upload by Default"

c) Make sure you are NOT using remote YUI

vBulletin Options -> Server Settings and Optimization Options

Use Remote YUI set to None

d) You may also need to clear your browser cache and/or vBulletin cache (Maintenance ->Clear system cache) if you have performed the above steps correctly but clicking the Upload button still does nothing.



2) Changes

11th January 2014

The parameter 'allowedDomain' has been sanitised with a REGEX to prevent malicious javascript being passed in a query string.


11th January 2014 v2

Many thanks to FranzBanz (http://www.vbulletin.com/forum/member/449383-franzbanz) for his suggestions
  • finding another exploit (using another parameter). Exploit fixed by setting the parameter (not used by vBulletin) to null.
  • '-' Character added to allowed characters in allowedDomain


Non-Flash Alternative
Please note that if you would rather avoid using flash altogether an alternative Mod has been released by BirdOPrey5, although there are some compromises/limitations with IE10+.

Asset Manager / Image Upload Fix to upload multiple files like the Flash uploader


DISCLAIMER
I am not a flash developer, I am just another vBulletin customer trying to keep his members happy!
This file is provided free of charge for the benefit of the vBulletin community. You use it at your own risk!


Copyright © 2013 Yahoo! Inc. All rights reserved.
Redistribution and use of this software in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

Neither the name of Yahoo! Inc. nor the names of YUI's contributors may be used to endorse or promote products derived from this software without specific prior written permission of Yahoo! Inc.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Download Now

Only licensed members can download files, Click Here for more information.

Show Your Support

  • To receive notifications regarding updates -> Click to Mark as Installed.
  • This modification may not be copied, reproduced or published elsewhere without author's permission.
  #16  
Old 15 Jan 2014, 21:05
keyla31's Avatar
keyla31 keyla31 is offline
 
Join Date: Feb 2009
ive done this but for some reason when I click select files a new box to browse computer files does not pop up? And ideas?
Reply With Quote
  #17  
Old 15 Jan 2014, 21:44
alexm's Avatar
alexm alexm is offline
 
Join Date: Apr 2005
Originally Posted by keyla31 View Post
ive done this but for some reason when I click select files a new box to browse computer files does not pop up? And ideas?
Try clearing your browser cache
Reply With Quote
  #18  
Old 15 Jan 2014, 22:49
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
Irrelevant posts and comments removed.

This is a modification release thread, not another "lets attack IB" thread.
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #19  
Old 16 Jan 2014, 04:47
MrD's Avatar
MrD MrD is offline
 
Join Date: Aug 2003
Real name: Marcus
Thx
__________________
Greetz from Dortmund/Germany
Marcus
Reply With Quote
  #20  
Old 17 Jan 2014, 15:29
keyla31's Avatar
keyla31 keyla31 is offline
 
Join Date: Feb 2009
Originally Posted by keyla31 View Post
ive done this but for some reason when I click select files a new box to browse computer files does not pop up? And ideas?
cleared browser like recommended and this worked, now working perfectly in 4.2.2 Thank you so so much
Reply With Quote
  #21  
Old 17 Jan 2014, 21:30
Thangvip9x Thangvip9x is offline
 
Join Date: Apr 2012
Real name: Thang
Working on vBulletin 4.2.2, thank you very much
Reply With Quote
  #22  
Old 18 Jan 2014, 13:42
Rebecca217 Rebecca217 is offline
 
Join Date: May 2002
Thank you so much for taking the time to fix this, and to make it available to the rest of us!
Reply With Quote
  #23  
Old 19 Jan 2014, 17:23
migratoria migratoria is offline
 
Join Date: Oct 2011
Tanks for the fix!
Reply With Quote
  #24  
Old 19 Jan 2014, 18:21
SomeSailor SomeSailor is offline
 
Join Date: May 2007
This should be included as a patch to all VB installs. Thank you very much!
Reply With Quote
  #25  
Old 20 Jan 2014, 19:54
tpearl5's Avatar
tpearl5 tpearl5 is offline
 
Join Date: Nov 2001
Real name: John
This should definitely be included as a patch! Thanks!
__________________
John
Reply With Quote
  #26  
Old 21 Jan 2014, 15:51
migratoria migratoria is offline
 
Join Date: Oct 2011
In vb 4.2.2 works...

Last edited by migratoria; 21 Jan 2014 at 17:10.
Reply With Quote
  #27  
Old 22 Jan 2014, 22:29
rootsxrocks rootsxrocks is offline
 
Join Date: Aug 2009
Thank you
__________________
Reply With Quote
  #28  
Old 23 Jan 2014, 01:44
Phaedrus Phaedrus is offline
 
Join Date: Aug 2006
Cool. Let's see if anybody at my site notices.
Reply With Quote
  #29  
Old 23 Jan 2014, 15:45
BarracodE's Avatar
BarracodE BarracodE is offline
 
Join Date: Sep 2010
Thank you so much. This issue was difficult to track down. Multiple images is very important to our users. Clearing the browser cache was the final missing piece. Thank you!
Reply With Quote
  #30  
Old 24 Jan 2014, 09:18
Jaydee 2 Jaydee 2 is offline
 
Join Date: Oct 2008
Real name: Jörg
Many thanks for this fix. It was an good idea!

I'll install it approximately in just one forum (just for testing it) and maybe later on in all the remaining ones.
Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Mod Options

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 17:19.

Layout Options | Width: Wide Color: