Register Members List Search Today's Posts Mark Forums Read

Reply
 
Mod Options
Patched Flash Uploader to Fix Known Exploits Details »
Patched Flash Uploader to Fix Known Exploits
Mod Version: 2.00, by alexm (Coder) alexm is offline
Developer Last Online: Jun 2021 I like it Show Printable Version Email this Page

vB Version: 4.x.x Rating: (33 votes - 4.88 average) Installs: 204
Released: 14 Jan 2014 Last Update: Never Downloads: 845
Supported Code Changes Additional Files  

UPDATE Dec 2014: 4.2.2 PL2, 4.2.2 PL3 and 4.2.3 core download packages from vBulletin now include this patched version of uploader.swf as standard.

This is a patched version of YUI 2.9.0 uploader.swf as used by vBulletin 4.x for managing multiple file uploads.

An exploit was found in the flash uploader (uploader.swf) file supplied with vBulletin 4.x. This file is part of the Yahoo YUI 2 Library which is end of life and Yahoo have stated that they will not be fixing it. Yahoo recommends that the file is removed as the flash uploader has been deprecated.

vBulletin's recommended fix is to replace the file with an empty file of the same name. If you do this, however, and rely solely on the Ajax uploader you will not be able to select multiple files without further modifications.

This modification is a recompiled version of uploader.swf with the above exploit fixed. An additional potential exploit has also been fixed by disabling a parameter not used by vBulletin.

The YUI source used is provided freely by Yahoo to whom I give full credit.


1) Installation

a) Extract uploader.swf from the .zip file and replace your existing file here:

<forum_root>/clientscript/yui/uploader/assets/uploader.swf

b) Make sure the flash uploader is enabled in the Admin Control Panel

Options -> Message Attachment Options -> Asset Manager - Enable -> Select "Yes, Flash Upload by Default"

c) Make sure you are NOT using remote YUI

vBulletin Options -> Server Settings and Optimization Options

Use Remote YUI set to None

d) You may also need to clear your browser cache and/or vBulletin cache (Maintenance ->Clear system cache) if you have performed the above steps correctly but clicking the Upload button still does nothing.



2) Changes

11th January 2014

The parameter 'allowedDomain' has been sanitised with a REGEX to prevent malicious javascript being passed in a query string.


11th January 2014 v2

Many thanks to FranzBanz (http://www.vbulletin.com/forum/member/449383-franzbanz) for his suggestions
  • finding another exploit (using another parameter). Exploit fixed by setting the parameter (not used by vBulletin) to null.
  • '-' Character added to allowed characters in allowedDomain


Non-Flash Alternative
Please note that if you would rather avoid using flash altogether an alternative Mod has been released by BirdOPrey5, although there are some compromises/limitations with IE10+.

Asset Manager / Image Upload Fix to upload multiple files like the Flash uploader


DISCLAIMER
I am not a flash developer, I am just another vBulletin customer trying to keep his members happy!
This file is provided free of charge for the benefit of the vBulletin community. You use it at your own risk!


Copyright Đ 2013 Yahoo! Inc. All rights reserved.
Redistribution and use of this software in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

Neither the name of Yahoo! Inc. nor the names of YUI's contributors may be used to endorse or promote products derived from this software without specific prior written permission of Yahoo! Inc.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Download Now

Only licensed members can download files, Click Here for more information.

Show Your Support

  • To receive notifications regarding updates -> Click to Mark as Installed.
  • This modification may not be copied, reproduced or published elsewhere without author's permission.
  #106  
Old 01 Dec 2014, 00:53
Lightly_Toasted Lightly_Toasted is offline
 
Join Date: Mar 2013
Stopped working out of the blue, went back to ajax and a blank swf file and uploads began working again.
__________________
Server Administrator
Forum Administrator TreatingYourself.ORG Current VB version: 4.2.1
Website Development
Reply With Quote
  #107  
Old 01 Dec 2014, 00:59
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Real name: Chris
That is because in the latest 4.2.2. patch and 4.2.3 this is included in the vb core.
Reply With Quote
  #108  
Old 08 Dec 2014, 03:51
dougdirac's Avatar
dougdirac dougdirac is offline
 
Join Date: Nov 2011
Does this patch still work or is it still needed after upgrading to 4.2.3 Beta?
Reply With Quote
  #109  
Old 08 Dec 2014, 10:04
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Real name: Chris
IIRC, this is included in 4.2.2. pl2 and 4.2.3
Reply With Quote
  #110  
Old 16 Dec 2014, 14:52
alexm's Avatar
alexm alexm is offline
 
Join Date: Apr 2005
For info

This patch is now included in 4.2.2 PL2/PL3/PL4 and 4.2.3/4.2.4/4.2.5 core downloads from vBulletin. If you are running 4.2.2 PL2 just check the version of uploader.swf you have as the earliest download package had the wrong version. I guess this is why uploader.swf was included again in the 4.2.2 PL3/PL4 patches just in case. It should be 7,410 bytes.

uploader.swf file hashes:

MD5: A2D3F12746C4552FA0757DB6D2D23F84
SHA1: 9F1A68F926BF3D9C9FF8848CB51561783A8A31FA

Last edited by alexm; 04 Jul 2017 at 18:44.
Reply With Quote
  #111  
Old 20 Dec 2015, 13:19
patracy patracy is offline
 
Join Date: Feb 2006
I tried this with my board 4.2.1, but the select files button does nothing?
Reply With Quote
  #112  
Old 20 Oct 2016, 11:16
MrD's Avatar
MrD MrD is offline
 
Join Date: Aug 2003
Real name: Marcus
Hi,
after the new flash update the Uploader donīt work
__________________
Greetz from Dortmund/Germany
Marcus
Reply With Quote
  #113  
Old 20 Oct 2016, 17:34
Dragonsys's Avatar
Dragonsys Dragonsys is offline
 
Join Date: Jan 2008
Real name: Eric
Originally Posted by MrD View Post
Hi,
after the new flash update the Uploader donīt work
What version of VB are you using?
Reply With Quote
  #114  
Old 23 Oct 2016, 12:51
MrD's Avatar
MrD MrD is offline
 
Join Date: Aug 2003
Real name: Marcus
Hi,
Vb4.2.3PL2

After Right click at the Button (that the flash Menu is open) and another click at the Button the uploader works.
__________________
Greetz from Dortmund/Germany
Marcus
Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Mod Options

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 09:39.

Layout Options | Width: Wide Color: