Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #1  
Old 16 Mar 2021, 02:31
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
PM on Promotion

Hi,

I would be interested by this mod under vB3 (maybe vB5 too).

https://www.vbulletin.org/forum/showthread.php?t=140629

No problem for the install. Promotions are done with no error message but no PM is sent to the user. No PHP error in the logs too. Tested on default style.

I will retest later.

Regards
Reply With Quote
  #2  
Old 16 Mar 2021, 03:14
TheLastBatman's Avatar
TheLastBatman TheLastBatman is offline
 
Join Date: Apr 2016
Real name: Batman
Not tested but in the install instructions change $pmdm =& datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY); to $pmdm = datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY);
Reply With Quote
  #3  
Old 16 Mar 2021, 03:55
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
Installed the product again, replaced the line of code and tested the promotion...

This time as it is said in the last message of the topic, the cron job does not work, the promotion is not done automatically. No PM sent to the user again.


In the logs:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

.

Last edited by lange; 16 Mar 2021 at 04:39.
Reply With Quote
  #4  
Old 16 Mar 2021, 06:21
TheLastBatman's Avatar
TheLastBatman TheLastBatman is offline
 
Join Date: Apr 2016
Real name: Batman
Got it working


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


Last edited by TheLastBatman; 16 Mar 2021 at 07:51.
Reply With Quote
  #5  
Old 16 Mar 2021, 11:57
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
I tested quickly by forcing promotions to 2 of my 11 usergroups and it works fine on PHP 7.4.x with no error message in the logs. I will restore my database and let the automatic promotion system go to see if it still works. I will give you some feedback but there is no reason that the automatic system does not work.

I only tested for the number of posts as a requirement for promotions. Do you think it will work if reputation is considered in promotions?

Anyway, I'll test that too before the feedback.

Thank you very much!
Reply With Quote
  #6  
Old 16 Mar 2021, 17:11
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
OK, tested on a clean new install/restored database.

The mod works well by manually running the promotion, the PM is sent and received correctly by the user. Unfortunately it's not working automatically, it's listed, enabled and scheduled in the scheduled task but the PM is not sent and received by the user. No PHP error in the log.

I checked the scheduled task log, it's listed. See the Attach File.
Log Phrase: Usergroup: <strong>{1}</strong>{2}; Users: {3}<dfn>* = Primary Usergroup, % = Secondary Usergroup</dfn>

The other tasks seem to work normally, at least for the Thread Views task. I did not check for other tasks.

Maybe something needs to be fixed in cron.php or some other files.

Regards
Attached Images
File Type: png 2021-03-16_11-42-21.png (3.8 KB, 2 views)

Last edited by lange; 16 Mar 2021 at 17:29.
Reply With Quote
  #7  
Old 16 Mar 2021, 22:05
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
I think I will use this mod by disabling the User Promotions cron on the list and manually running it once a day for example. It just remains to check if everything else is working properly.
Reply With Quote
  #8  
Old 17 Mar 2021, 00:38
Seven Skins's Avatar
Seven Skins Seven Skins is offline
 
Join Date: Sep 2008
See if this helps...

Change this line:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.



TO:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Reply With Quote
  #9  
Old 17 Mar 2021, 00:53
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
Thanks

It's already included there

Tested this morning.
Reply With Quote
  #10  
Old 17 Mar 2021, 01:00
TheLastBatman's Avatar
TheLastBatman TheLastBatman is offline
 
Join Date: Apr 2016
Real name: Batman
yeah if the auto cron isnt running that may be an issue else were, I had a member on my site report they never received a registration verification email either, so there may be a hick-up in the php 7.4 version.
Reply With Quote
  #11  
Old 17 Mar 2021, 11:08
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
I will try to use the cPanel cronjob to make the PHP promotion cron work.
Reply With Quote
  #12  
Old 17 Mar 2021, 18:11
TheLastBatman's Avatar
TheLastBatman TheLastBatman is offline
 
Join Date: Apr 2016
Real name: Batman
let me know if that works, are you using 3.8.14 also? and if so are auto emails being sent for registration for you?
Reply With Quote
  #13  
Old 17 Mar 2021, 18:59
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
OK, I will respond to the topic if it works on cPanel.

Yes all email stuff works otherwise I wouldn't use 3.8.x especially since my forum is totally private (by invitation only) with only a very small login box as homepage.

Send Welcome Email
Welcome Private Message
Email Address to Notify About New Members
Verify Email address in Registration

Right now, it is 7.4.9. A few weeks ago, it was 7.4.11, I don't know the reason for the version downgrade.
Attached Images
File Type: png 2021-03-17_13-39-36.png (11.6 KB, 7 views)
Reply With Quote
  #14  
Old 10 Apr 2021, 10:25
lange's Avatar
lange lange is offline
 
Join Date: Apr 2003
Feedback

I tried the cron with all possible permutations. This does not work under PHP 7.4. Not tested with previous versions.


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Reply With Quote
Reply



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 03:55.

Layout Options | Width: Wide Color: