Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #31  
Old 11 Jul 2012, 21:12
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Ummm hmm let me try something real quick NO the other did not insert a link in the outgoing emails.

--------------- Added 11 Jul 2012 at 21:17 ---------------

Ok with the old one I'd visit urlhere/misc.php?do=unsub and click the unsubscribe button.

This one when I visit urlhere/misc.php?do=unsub I see my smilies page

So I have no idea what's going on right now
Reply With Quote
  #32  
Old 11 Jul 2012, 21:19
kh99 kh99 is offline
 
Join Date: Aug 2009
Real name: Kevin
Oh, sorry, that is my fault. I decided to change the "do" values so that they wouldn't conflict with the other mod (which now that I think about it might not have been a good idea since some people might want to replace the other mod with this one).

Anwyay, the current one uses do=unsubscribe instead of do=unsub.

--------------- Added 11 Jul 2012 at 21:26 ---------------

I guess I should try that dbtech mod. So far this hasn't been a big deal, but before I spend any more time I should make sure I'm not making a poor imitation of what they've done already.
Reply With Quote
  #33  
Old 11 Jul 2012, 21:27
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Ok it works But it can't find phrase klh99_unsublink_done

--------------- Added 11 Jul 2012 at 21:28 ---------------

If you don't mind I'll be tweaking it to turn off those other options as well just to cover my butt
Reply With Quote
  #34  
Old 11 Jul 2012, 21:33
kh99 kh99 is offline
 
Join Date: Aug 2009
Real name: Kevin
Originally Posted by John Lester View Post
Ok it works But it can't find phrase klh99_unsublink_done

--------------- Added 11 Jul 2012 at 21:28 ---------------

If you don't mind I'll be tweaking it to turn off those other options as well just to cover my butt
Yeah, a phrase or two was misnamed (I went and renamed everything because I like to add kh99 and mod name just to avoid possible comflicts). I've been working on little things like that in the current version.

Tweaking what to turn off what? You can do whatever you want of course, but if you want to install the final mod when it's done then you probably won't want to do a lot of phrase editing just yet (unless you don't mind repeating it )

I'm going to try to release a first version tonight. If nothing else that will let us continue this discussion in the mod thread instead of annoying everyone in the forum by continuously bumping this thread .
Reply With Quote
  #35  
Old 11 Jul 2012, 21:36
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Right now your version only deselects "receive emails from admin", the older one that I tweaked deselects a few more options and sets thread subscriptions to "do not subscribe".

I forgot to attach the tweaks I made to the older mod for you to see

I changed the name of the mod so I wouldn't import the wrong one, but the attached is the old mod with my tweaks.
Attached Files
File Type: xml product-advanced_unsubscribe_link_4.0.xml (8.1 KB, 4 views)
Reply With Quote
  #36  
Old 11 Jul 2012, 21:40
kh99 kh99 is offline
 
Join Date: Aug 2009
Real name: Kevin
Originally Posted by John Lester View Post
Right now your version only deselects "receive emails from admin", the older one that I tweaked deselects a few more options and sets thread subscriptions to "do not subscribe".

I forgot to attach the tweaks I made to the older mod for you to see

I changed the name of the mod so I wouldn't import the wrong one, but the attached is the old mod with my tweaks.
Oh, I see. Good, I'll take a look at that. Yeah, I was thinking about a set of checkboxes for what it should turn off, in the adminCP and maybe optionally on the user form (where you enter the email) so a user could decide what to opt out of.

--------------- Added 11 Jul 2012 at 21:42 ---------------

BTW, I think setting autosubscribe to -1 just stops the automatic adding of subscriptions to threads. If you want to also delete existing subscriptions, you'd have to delete the records from the subscription tables.

Last edited by kh99; 11 Jul 2012 at 21:46.
Reply With Quote
  #37  
Old 11 Jul 2012, 21:47
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Yes all it does is change the setting, I haven't even attempted to delete existing subscriptions because technically it's not needed since deselecting "receive email from admins" stops them from being sent.

At least that is my understanding of what "receive email from admins" actually does.

--------------- Added 11 Jul 2012 at 21:48 ---------------

The reason I added the change to subscriptions was basically just testing to make sure I understood what I was doing

--------------- Added 11 Jul 2012 at 21:49 ---------------

As you probably have seen with my tweaked version of the old mod, I'll be changing the phrase to something very similar depending on the final product
Reply With Quote
  #38  
Old 11 Jul 2012, 21:54
kh99 kh99 is offline
 
Join Date: Aug 2009
Real name: Kevin
Originally Posted by John Lester View Post
Yes all it does is change the setting, I haven't even attempted to delete existing subscriptions because technically it's not needed since deselecting "receive email from admins" stops them from being sent.

At least that is my understanding of what "receive email from admins" actually does.
Hmm...if it's important to you then I'd test that. Looking at the code, it doesn't look like that's true. In fact after a quick glance it looks like the only things affected by the admin email setting is birthday emails, infraction notices, and emails sent from the admincp (but I may have missed a few things).

I'll try to have a somewhat stable version tonight so you don't have to change things more than once (unless of course you're happy with the current one, then you don't really *have* to install any other version).
Reply With Quote
  #39  
Old 11 Jul 2012, 22:16
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Well the only emails we send out are: birthday, subscriptions, pm notifies, infractions, and some user to user emails.

I will be putting the url in every "email body text" so I should be covered either way No need to go digging around for past subscription stuff

--------------- Added 11 Jul 2012 at 22:46 ---------------

Well now this is a bit odd, when I click on the "more" link on my smilie page it tells me it can't find the phrase unsubscribe_done and redirects me to the index page O.o

Last edited by John Lester; 11 Jul 2012 at 22:47.
Reply With Quote
  #40  
Old 11 Jul 2012, 23:28
kh99 kh99 is offline
 
Join Date: Aug 2009
Real name: Kevin
Originally Posted by John Lester View Post
Well the only emails we send out are: birthday, subscriptions, pm notifies, infractions, and some user to user emails.

I will be putting the url in every "email body text" so I should be covered either way No need to go digging around for past subscription stuff
Well, in a way that would only make the situation worse, if there was a link but it didn't actually stop the emails.

I've been trying to test if turning off admin emails stops subscription emails, but I'm frustrated by the fact that it can take 10 minutes or more just to receive an email that I send myself. I guess I need to put debug statements in the code to make sure.


Well now this is a bit odd, when I click on the "more" link on my smilie page it tells me it
can't find the phrase unsubscribe_done and redirects me to the index page O.o

What does the url say? I don't see how that could happen in my mod - all the code is inside if statements checking the value of "do".

--------------- Added 11 Jul 2012 at 23:43 ---------------

OK - I'd feel better if I could do a "real" test with emails, but I'm pretty sure that turning off admin emails doesn't stop subscription emails. I think the idea is that the users have control over what they subscribe to, so there's no need for a setting.

But, it OK because it's actually an easy query or two to remove all subscirptions for a user.

Well, OK, more than a couple. I was just looking at the database and there's also socialgroup group and discussion subscriptions and event reminders.

Edit: ..and one more thing, I was hoping to release this tonight but I think I'm done with this stuff for today, I hope that's not a problem.

--------------- Added 12 Jul 2012 at 00:24 ---------------

One more thing - I think I am being stupid. While I was testing the subscription emails I noticed that not only does it already contain a link to remove the subscription, the link also has some kind of "auth" code that removes the subscription in one click without needing to log in. I'm going to look in to that tomorrow.

Last edited by kh99; 12 Jul 2012 at 00:25.
Reply With Quote
  #41  
Old 12 Jul 2012, 02:22
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Yes I saw that unsubscribe auth link while going through the phrases for email body text. I also saw a couple of links that led to the usercp being used as unsubscribe links.

Either way, what you've done works awesome as far as my host is concerned, and I've already gone though all of the email body text phrases adding the link to your mod and removing any others I found.

I suppose I could have done it the other way around, but I didn't look at what the unsubscribe links did and felt my way was just ... easier

No problem at all with the release not being tonight I'll do some more sleuthing when it cools off here in regards to the smilie page issue and get back to you.

--------------- Added 12 Jul 2012 at 02:38 ---------------

Ok the message that pops up is - could not find phrase unsubscrib_done and then sends me to the index page

You are correct, turning off "receive admin emails" does not stop thread subscriptions (and I'm going to assume group and others as well), and I think I figured that out yesterday which is why I added the condition to set thread subscriptions to "do no subscribe". I figured doing that and adding the unsubscribe link would be enough to cover my butt ... and the host agrees. In fact they wonder why I bothered adding all of that other stuff ... but screw them they suck
Reply With Quote
  #42  
Old 12 Jul 2012, 03:35
ForceHSS's Avatar
ForceHSS ForceHSS is offline
 
Join Date: Apr 2008
You should post this as a plugin once all bugs are worked out
Reply With Quote
  #43  
Old 12 Jul 2012, 03:54
John Lester's Avatar
John Lester John Lester is offline
 
Join Date: Nov 2004
Originally Posted by ForceHSS View Post
You should post this as a plugin once all bugs are worked out
I believe he (Kevin) intends to do just that

--------------- Added 12 Jul 2012 at 03:56 ---------------

Originally Posted by John Lester View Post
Ok the message that pops up is - could not find phrase unsubscrib_done and then sends me to the index page
I figured out why this was happening. During my sleep deprived state last night comparing the new version and the old version I accidentally copied over a snipet of code from the old version and imported the contaminated version to my live site Once I removed the code everyone works properly now
Reply With Quote
  #44  
Old 12 Jul 2012, 10:25
kh99 kh99 is offline
 
Join Date: Aug 2009
Real name: Kevin
OK, I'm glad you got the error message worked out. Sounds like you've pretty much got yourself straightened out. As fo rthe thread subscription unsubscribe links, I had a look and it's actually pretty much the same thing we're doing. The auth code is a hash of the user id and subscription id, and it's used to unsubscribe without needing to log in, the same as we're using the email address. I think in general it might still be useful to expand the page on our mod to let the user choose what they want to unsubscribe from, and have an "I don't want any more email" box.

When you said your host "wonders why you bothered adding all of that other stuff", what do you mean exactly - that you added another unsubscribe link to the subscription emails?

In any case, do you need anything else? If you're all set with your host I'll just take my time (...and probably never get it released ).
Reply With Quote
  #45  
Old 12 Jul 2012, 10:34
Simon Lloyd's Avatar
Simon Lloyd Simon Lloyd is offline
 
Join Date: Aug 2008
Real name: Simon
Originally Posted by kh99 View Post
In any case, do you need anything else? If you're all set with your host I'll just take my time (...and probably never get it released ).
That would be a crying shame as that should be built in to vb!
__________________
Kind regards,
Simon Microsoft Office Help
My Mods: Find my modifications here
Please do not pm me for support unless i have invited you to!
Reply With Quote
Reply

Similar Threads
Thread Thread Starter Forum Replies Last Post
Administrative and Maintenance Tools Email Rules - Require that users' email addresses match a regular expression Analogpoint vBulletin 3.8 Add-ons 15 03 May 2013 13:26



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 08:12.

Layout Options | Width: Wide Color: