[ehsanix]

Thanks for the update

[sevenmix]

Originally Posted by entertain

I've never seen iTrader for SMF nor the database structure of it. Sorry.
Here take a look:

Attachment 136004

Hi

In this new version is this upgrade already? Because im already using it on my forum and i dont want to miss it :S

[entertain]

About the security issue in iTrader 2.8.2 RC2: I had to work a lot the last few weeks, my mail address here at vBulletin.org was an old one and this is why I did not get any notification. Sorry for the inconvenience!

@sevenmix:
It is only necessary to rewrite itrader_main.php. However, I am trying to release a bigger update the next two weeks, where this will be included.

[sevenmix]

Originally Posted by entertain

About the security issue in iTrader 2.8.2 RC2: I had to work a lot the last few weeks, my mail address here at vBulletin.org was an old one and this is why I did not get any notification. Sorry for the inconvenience!

@sevenmix:
It is only necessary to rewrite itrader_main.php. However, I am trying to release a bigger update the next two weeks, where this will be included.

Thanks i will be waiting that release.

[entertain]

Thank you very much sevenmix for this kind donation!!!

[TiKu]

@entertain:
May I suggest to use the following function to compare version strings?

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

The function will return 1 if verstr1 > verstr2, -1 if verstr1 < verstr2 and 0 if they are equal.

[entertain]

@TiKu:

please tell me where this is needed?!

[TiKu]

I've seen 2 or 3 lines in the source code where you compare VB's template version against '4.1.3'. Before the release of VB 4.1.10 you simply used templateversion > '4.1.3' which was okay. Starting with 4.1.10 you had to use something else. Now you're doing it like this:
templateversion > '4.1.3' || inarray(templateversion, '4.1.10', '4.1.11')
This forces you to update the code on each new VB release. Also as a software developer I have to say that this code isn't very pretty.

[fwulfers]

Thanks so much for fixing the security issue and make this available again. I installed this today and have a small issue. When someone leaves feedback, the system sends out 2 PMs right after each other. The first pm has a wrong link:

Details about this transaction can be found *on your iTrader page* (http://2/itrader.php?u=2).

The second pm has the correct link:

Details about this transaction can be found *on your iTrader page* (http://saabworld.net/itrader.php?u=2).

Why is it sending that first pm with the wrong link (number replaces the domain name) and how can it be eliminated?

[meissenation]

thanks for the patch!

[wmturkey]

I've just installed it on 4.1.10, followed all the instructions to the letter, and it's not showing up on the forum. Any hints?

Thanks!

Edit: Didn't enable it in Settings > Options. Working now. Thanks!

[entertain]

Thank you very much meissenation for this donation!!!

[entertain]

@fwulfers:
I will check it today, when I can reproduce it, I will post a fix here!

@wmturkey:
Glad to hear that it is working. I hope you can give me a feedback when you like it (or even don't).

[entertain]

Originally Posted by fwulfers

Thanks so much for fixing the security issue and make this available again. I installed this today and have a small issue. When someone leaves feedback, the system sends out 2 PMs right after each other. The first pm has a wrong link:


The second pm has the correct link:



Why is it sending that first pm with the wrong link (number replaces the domain name) and how can it be eliminated?

Sorry, not reproducible for me with vBulletin 4.1.10. Anyone else has this issue?

[Baja]

Thank you for the patch!

Might I suggest an increase in the version number: 2.8.2 RC2 -> RC3?

Also I previously deleted itrader_main.php. Can you confirm that was the only file affected? You see, Lynne mentioned a 2nd issue in the post below. I was unclear if he meant two problems in itrader_main.php or somethig else entirely.

http://www.vbulletin.org/forum/showp...0&postcount=31