[vHBolo]

thanks bots have been getting bad lately for me

[Chadi]

This is not working accurately for me.

Instead of stopping the member from posting links, it simply puts their message in moderation queue. Why?

My settings are right and used to work fine prior to upgrading to 3.7.4 vb.

My test post was a test member (member group) with 0 post count.

The body was simply

"test post

test.com"

Thanks for your help

[ShackMaster]

I came from the other thread where I was having an issues and asked that someone upgrade this mod. Thanks for you work, however, I am still experiencing a problem. I have usergroups listed under the following section in AdminCP:

Plugin Usergroup Ignore List
List of usergroup ID's that this plugin will not affect.

Even if they are listed for the plugin to not affect them, it still sends their posts to moderation queue if they have less than 5 posts.

I do not mind chipping in if this is fixed.

Thanks!

[h2ojunkie]

Originally Posted by chadi

This is not working accurately for me.

Instead of stopping the member from posting links, it simply puts their message in moderation queue. Why?

My settings are right and used to work fine prior to upgrading to 3.7.4 vb.

My test post was a test member (member group) with 0 post count.

The body was simply

"test post

test.com"

Thanks for your help

Read the description, I changed the modification to work this way on purpose.

URL spam is now sent to the moderation que just like keyword spam. I didn't like the original way the mod posted URL spam to a private forum, or stopped it all together since too many valid posts were lost and it discourages new members from participating in the site. So now it just moderates all spam so a moderator can decide to delete or allow it.

Originally Posted by ShackMaster

I came from the other thread where I was having an issues and asked that someone upgrade this mod. Thanks for you work, however, I am still experiencing a problem. I have usergroups listed under the following section in AdminCP:

Plugin Usergroup Ignore List
List of usergroup ID's that this plugin will not affect.

Even if they are listed for the plugin to not affect them, it still sends their posts to moderation queue if they have less than 5 posts.

I do not mind chipping in if this is fixed.

Thanks!

2 things:
1) is your list of usergroups separated with commas?
2) the modification originally only checked the primary usergroup of the member, I've now updated it to check the primary and secondary usergroups.

D/L the update as I suspect your problem was due to the usergroups you were trying to ignore being secondary usergroups

If you continue to have problems, uninstall the original, and re-install just to be sure your settings are correct.

I have tested this on 3.7.4 and 3.8.0RC1/2 and it works fine.

[Chadi]

Originally Posted by h2ojunkie

Read the description, I changed the modification to work this way on purpose.

URL spam is now sent to the moderation que just like keyword spam. I didn't like the original way the mod posted URL spam to a form, and moderated keyword spam. So now it just moderates all spam.

That doesn't really make any sense. It contradicts the purpose of 'no links' unless x amount of posts are made. The whole purpose is to prevent them from posting links in the first place, not mark them as spam. The spam keyword area has its own section and does its own purpose.

After all the description says

"Only users with this number of posts or less will be stopped from posting URL links."

Its obviously not 'stopping' anything, only sending them to mod queue.

Maybe you can provide both options to choose from? That'll be great at least.

[h2ojunkie]

Originally Posted by chadi

That doesn't really make any sense. It contradicts the purpose of 'no links' unless x amount of posts are made. The whole purpose is to prevent them from posting links in the first place, not mark them as spam. The spam keyword area has its own section and does its own purpose.

After all the description says

"Only users with this number of posts or less will be stopped from posting URL links."

Its obviously not 'stopping' anything, only sending them to mod queue.

Maybe you can provide both options to choose from? That'll be great at least.

I get what you're saying, but I have no personal use for the mod in it's original form.

When I tested the original mod live in the original version. I kept getting new members making posts like "I'm not allowed to post URL's until I hit 10 posts, so I'm posting this to get my post count up"

I only uploaded my revised version of it because it was requested in the thread for the old version.

Personally, I see no reason to moderate the word ipod, but delete/block a URL. Either one may be a valid post and chasing away a new member by not letting them make a valid post makes no sense to me.

And I'd much rather catch a spammer that joined my site through moderated posts so I can ban them instead of just blocking the URL and never knowing I have a spammer who may then go on to spam via PM in the background without me ever knowing.

I don't like the idea of giving a spammer a message that says "Hey, make 3 or 4 more good posts, and then we'll stop blocking your URLs and let you spam away after that"

The moderation que gives me the option to either ban the spammer, or allow a good post through and not discourage a new member from participating.


P.S. I will update the phrase in the settings screen to clarify.

I didn't really look to see what was not working in the original other than the secondary user groups. If that's the only problem you had with the original. Take a look at what I changed on the 1st line of the plugin Check4SPAM - Scan and moderate (newpost_process) to support secondary usergroups and apply that change to the original version.

[woostar]

Hi all,

Really sorry for not being about. I've had shed loads of work that's got in the way of personal projects (this was written for my forum and only an after thought to release publicly).

I don't mind if anyone want to carry on modding this code (although if you had PM'd I would have replied).

Personally I wouldn't send all URL's to be moderated (at least give an option to ban or send to be moderated). Not sure why some people are having problems with the original release. I get about 150k posts a month and never had any problems.

I have slowly been working on this mod on my forum. Maybe h2ojunkie or anyone else who want to reuse the code wants to incorporate some of my unfinished ideas and beta code, I've attached a working but beta product (note the beta plugins are not active so you'll have to turn them on if you want to test).

I have no problem in the code being reused, but in the new year when I have more time I may want to release another version. We may go in different directions so would probably be best to pick a new name (all I ask is a small credit for the reused code in your new creation ).

Things that work in the beta:

• 3 strikes and timeout - After the 3rd try on posting a URL the user will be unable to post for 10 minutes (10 mins by default but you can set how long in admincp). I was going to add ban or timeout option.
• Fixed the edit post bug where users can go back and edit posts and by pass spam filter.
• Tweaked the URL detection method.

Things I think work but needs checking:

• PM Spam filter.
• Signature Spam filter.

Suggestions:

• The main spam code is a fair few times on different hooks. I would make it into a function and call it as needed.
• Needs adding the spam filter to groups and profile messages.

I will make another release soon but give me time to get rid of my backlog of work.

Regards,
W.>

[Alfa1]

How can I fix this bug?

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

I see that multiple people have this bug, as there are also posts about this on vb.com

[woostar]

Originally Posted by Alfa1

How can I fix this bug?

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

I see that multiple people have this bug, as there are also posts about this on vb.com

do you get this just when posting a normal none spam post?

Do you have the link to the vb.com post handy?

[woostar]

ahhhhhhhhh - I think I know why....

These lines:

foreach ($allowedurls as $allowedurl) {
$message = (preg_replace('/(\[url=?"?\]?)(https?\:\/\/)?(www\.)?' . $allowedurl . '\/?"?\]?(.*?)?\[\/url\]/i', '', $message));
}

should be:

foreach ($allowedurls as $allowedurl) {
$allowedurl = str_replace('/', '\/', $allowedurl);
$message = (preg_replace('/(\[url=?"?\]?)(https?\:\/\/)?(www\.)?' . $allowedurl . '\/?"?\]?(.*?)?\[\/url\]/i', '', $message));
}

Will have to have a proper look at the code.

Maybe h2ojunkie can confirm.

[Chadi]

Originally Posted by woostar

Hi all,

Really sorry for not being about. I've had shed loads of work that's got in the way of personal projects (this was written for my forum and only an after thought to release publicly).

I don't mind if anyone want to carry on modding this code (although if you had PM'd I would have replied).

Personally I wouldn't send all URL's to be moderated (at least give an option to ban or send to be moderated). Not sure why some people are having problems with the original release. I get about 150k posts a month and never had any problems.

I have slowly been working on this mod on my forum. Maybe h2ojunkie or anyone else who want to reuse the code wants to incorporate some of my unfinished ideas and beta code, I've attached a working but beta product (note the beta plugins are not active so you'll have to turn them on if you want to test).

I have no problem in the code being reused, but in the new year when I have more time I may want to release another version. We may go in different directions so would probably be best to pick a new name (all I ask is a small credit for the reused code in your new creation ).

Things that work in the beta:

• 3 strikes and timeout - After the 3rd try on posting a URL the user will be unable to post for 10 minutes (10 mins by default but you can set how long in admincp). I was going to add ban or timeout option.
• Fixed the edit post bug where users can go back and edit posts and by pass spam filter.
• Tweaked the URL detection method.

Things I think work but needs checking:

• PM Spam filter.
• Signature Spam filter.

Suggestions:

• The main spam code is a fair few times on different hooks. I would make it into a function and call it as needed.
• Needs adding the spam filter to groups and profile messages.

I will make another release soon but give me time to get rid of my backlog of work.

Regards,
W.>

Good to hear from you. I agree, sending all url's to be moderated is purposeless and defeats having a minimum post requirement before they are entitled to posting url's. If you can please fix your original mod to work in 3.7.4 that'll be great. I'll donate.

[h2ojunkie]

Since woostar is back, I'm going to pull this mod down.