Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #1  
Old 12 Aug 2016, 09:59
kerrghann's Avatar
kerrghann kerrghann is offline
 
Join Date: Jul 2012
Real name: Markis
Trouble with Custom Script

So...I decided to improve on the default passwordcheck.php in the admincp. Rather then just checking to see if my users passwords are just their username, I decided to modify it to use an array that I've filled with the top 25 most commonly used passwords.

And it works! Kind of. It tells you the correct number of users (I assume) that meet the check criteria, however, for some reason when you reset those users passwords, the script continues past the number of people that it says have the vulnerable passwords and keeps climbing up and up, resetting passwords until I stop it.

Anyone feel up for helping?


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

__________________
A Place to create; a place to innovate~
Reply With Quote
  #2  
Old 12 Aug 2016, 11:10
nhawk nhawk is offline
 
Join Date: Jan 2011
$user can't be used twice the way you're using it. The while loop will never end.


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Reply With Quote
  #3  
Old 12 Aug 2016, 22:52
kerrghann's Avatar
kerrghann kerrghann is offline
 
Join Date: Jul 2012
Real name: Markis
Oddly enough that isn't a part that I modified. That's part of the normal vbulletin script. It also works fine and doesn't go on forever, at least until I add my part:

My parts are these:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

and


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

and


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

__________________
A Place to create; a place to innovate~
Reply With Quote
  #4  
Old 12 Aug 2016, 23:11
RichieBoy67's Avatar
RichieBoy67 RichieBoy67 is offline
 
Join Date: Apr 2004
Real name: Richie
I think it is supposed to be $badPasswords
__________________

Let us take care of your forum, seo, seo reports, maintenance, what ever you need.

Reply With Quote
  #5  
Old 13 Aug 2016, 08:36
kerrghann's Avatar
kerrghann kerrghann is offline
 
Join Date: Jul 2012
Real name: Markis
Nope. I set my array to be $badPassword[0] - $badPassword[24]
__________________
A Place to create; a place to innovate~
Reply With Quote
Reply



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 03:56.

Layout Options | Width: Wide Color: