Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #1  
Old 02 Dec 2009, 18:21
rebelde rebelde is offline
 
Join Date: Jun 2008
split 'DB changes' into 'DB table modifications' and 'DB table additions'

Hi,

The checkmark beside "DB changes" has been great. It tells me to not even consider a mod, 'cause nothing is allowed messing with my database.

BUT, I would consider some DB changes if they only added tables, instead of modifying vB's tables. By splitting
'DB changes'
into
'DB table modifications' and
'DB table additions'
I will know better which mods I might consider if really useful.

An additional benefit is that it would encourage mod developers to create new tables instead of altering existing tables. (We might even try to standardize table names so it will be obvious where they came from. Something like this for a table name: 'vborgFacebookConnect')

Thanks for listening and I hope this is a helpful comment!
Reply With Quote
  #2  
Old 02 Dec 2009, 18:22
Adrian Schneider's Avatar
Adrian Schneider Adrian Schneider is offline
 
Join Date: Jul 2004
Agree with the split, but not with the table names. That would mess up code quite a bit, and it's just semantically incorrect for me. Use table comments for that.
Reply With Quote
  #3  
Old 02 Dec 2009, 18:34
rebelde rebelde is offline
 
Join Date: Jun 2008
Ha! I'll be thrilled if just the first suggestion leads to something.
Reply With Quote
  #4  
Old 02 Dec 2009, 18:42
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
Thank you for the suggestion but we wont be splitting db changes into two.
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #5  
Old 02 Dec 2009, 18:54
rebelde rebelde is offline
 
Join Date: Jun 2008
Haha. That was quick. I did plant the idea in your mind, Paul, and maybe a year from now you will like it.

Cheers
Reply With Quote
  #6  
Old 03 Dec 2009, 11:18
Carnage Carnage is offline
 
Join Date: Jan 2005
I think it really depends whats modified.

Many of my mods add tables; I try to design to add not edit where ever possible. However sometimes you just need an extra coloumn somewhere.

Provided that the uninstall code reverts the db to the state it was in before the mod was isntalled; I dont see much of an issue.
__________________
www.giveupalready.com

If you want/need to contact me, best thing is to pm me on that site, username Carnage.
Reply With Quote
  #7  
Old 03 Dec 2009, 11:31
Dean C's Avatar
Dean C Dean C is offline
 
Join Date: Jan 2002
Real name: Dean Clatworthy
You're being overly paranoid. There's no queries in vB3 that I can remember which depend on the total amount of columns in your table. Therefore adding columns will not do any harm at all.
__________________
Dean Clatworthy - Web Developer/Designer
Reply With Quote
Reply



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 09:44.

Layout Options | Width: Wide Color: