[akanevsky]

First Post Reserved.

[CrazyProgrammer]

Thanks GJ Trying it out now

[Almotmaiz.Net]

Thanks
Installed

[TheInsaneManiac]

Excuse me for not fully understanding this, but I don't. It looks like all it does is add the users name in bold, however the built in quote feature of VBulletin already will quote the users name for you.

[akanevsky]

Originally Posted by TheInsaneManiac

Excuse me for not fully understanding this, but I don't. It looks like all it does is add the users name in bold, however the built in quote feature of VBulletin already will quote the users name for you.

This is all a question of usability and preference. Some people - like myself, for example - like to quote parts of posts right in the quick reply, as opposed to quoting whole posts in the advanced editor. Sometimes they also want to write address someone quickly in the quick reply without quoting anything and without having to type the username manually, hence there is another link just for that. Of course, there are a lot of people who do not think that this is useful, but I am not making anyone install this hack.

[nohuhu]

Psionic Vision,

there's something i cannot understand in readme for this mod. it says, in file /clientscript/vbulletin_textedit.js find "// vB_Text_Editor methods" and append some text after this line. but in my 3.8.2 the vbulletin_textedit.js is "compressed", there are no comments in there. where do i insert your additional text? ain't it possible not to change vanilla vbulletin_textedit.js but add your script as separate file instead?

[akanevsky]

You can always download the uncompressed vBulletin from the vBulletin client area.

[nohuhu]

Psionic Vision,

that's what i did exactly. but you see, "compressed" javascript means it has no comments, no extra whitespace except bare minimum, it's stripped of all unnecessary characters to save bandwidth. effectively it's one line of code and the only comment box it has is its header stating it's vBulletin 3.8.2, copyrights blah-blah-blah. so where do i insert your code?

[akanevsky]

You have to download the uncompressed version first, so that you can edit the files.

[nohuhu]

Psionic Vision,

ok, now i got it. sorry for me being stupid.

[nohuhu]

Psionic Vision,

got it working. have an issue though: when editor is set to wysiwyg mode, using either "insert name" or "quick quote" functions produces an extra line break before inserted text. i took a look at your code and this behaviour seems to be expected as you check length of existing editor contents before inserting your own but somehow it doesn't work as expected with wysiwyg mode. in simple editor mode it works ok and only inserts extra line break when there is already some content in editor field. can you check this please?

also i have a feature request of a sorts: can you make your script to set focus on editor field after inserting either quote or username? that would be logical i think, usually i want to start writing my message immediately after quoting or addressing someone. i tried to append "this.focus()" call after "this.set_editor_contents()" but somehow it doesn't work. sorry i'm no javascript expert...

[akanevsky]

got it working. have an issue though: when editor is set to wysiwyg mode, using either "insert name" or "quick quote" functions produces an extra line break before inserted text. i took a look at your code and this behaviour seems to be expected as you check length of existing editor contents before inserting your own but somehow it doesn't work as expected with wysiwyg mode. in simple editor mode it works ok and only inserts extra line break when there is already some content in editor field. can you check this please?

That is a known bug. In WYSIWYG, there's some hidden formatting that causes the message length function to report a random non-zero number when the message area is empty - and I don't know how to work around the problem at this time.

also i have a feature request of a sorts: can you make your script to set focus on editor field after inserting either quote or username? that would be logical i think, usually i want to start writing my message immediately after quoting or addressing someone. i tried to append "this.focus()" call after "this.set_editor_contents()" but somehow it doesn't work. sorry i'm no javascript expert...

A lot of people want to quote multiple things before starting to type a reply. If the focus kept jumping to message area every time, that would be very annoying to those people.

[nohuhu]

Originally Posted by Psionic Vision

That is a known bug. In WYSIWYG, there's some hidden formatting that causes the message length function to report a random non-zero number when the message area is empty - and I don't know how to work around the problem at this time.

ok then, i'll have to advise my users not to use wysiwyg mode for quick reply.

A lot of people want to quote multiple things before starting to type a reply. If the focus kept jumping to message area every time, that would be very annoying to those people.

i got your point but my users got used to phpbb behaviour and it focused on message area after clicking on username. i myself find it convenient too. is it possible to make it configurable? if not and you don't want to include this feature in your mod, can you advise me on how to do it then? i have no trouble running customized mods.

[nohuhu]

Psionic Vision,

never mind that, i already figured it out myself.