Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #1  
Old 30 Jul 2012, 16:43
chefy chefy is offline
 
Join Date: Jul 2012
Bug when quoting members with "[" or "]" in their nicknames

We will use for this example a random member: [Dx]. So imagine that you're quoting a post from [Dx] then the quote code should look like this:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

However it's being parsed as this:



Breaking the quote tag.

Please fix this at vB.org and also share with us the instructions so we all the users of vB 3.x will be able to apply the fix in our own forums.
Attached Images
File Type: png bugxd.png (14.3 KB, 122 views)
Reply With Quote
  #2  
Old 31 Jul 2012, 18:20
chefy chefy is offline
 
Join Date: Jul 2012
I can confirm that this bug is also present in vB 4.2
Reply With Quote
  #3  
Old 31 Jul 2012, 19:29
Ziki's Avatar
Ziki Ziki is offline
 
Join Date: Nov 2005
Nice catch

Also install quote notifications on vb.org!
__________________
My free mods~click here
Reply With Quote
  #4  
Old 31 Jul 2012, 20:52
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
The fix is not to allow [ or ] in usernames.

Its bound to clash with any BB code, not just quote, and would be very difficult to do anything about.
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #5  
Old 31 Jul 2012, 23:01
Simon Lloyd's Avatar
Simon Lloyd Simon Lloyd is offline
 
Join Date: Aug 2008
Real name: Simon
If you must allow daft characters in the usernames you'll have to work out a way of encapsulating it in [noparse]
__________________
Kind regards,
Simon Microsoft Office Help
My Mods: Find my modifications here
Please do not pm me for support unless i have invited you to!
Reply With Quote
  #6  
Old 01 Aug 2012, 23:14
DivisionByZero's Avatar
DivisionByZero DivisionByZero is offline
 
Join Date: Dec 2002
Real name: Chris
i got sick of names like |< () R |\| and other crap a LONG time ago and disabled all but letters, numbers, underscores and dashes.
__________________
Professional vB development since 2002.
References & Praise: 1|2|3|4|5|6|7|8
Reply With Quote
  #7  
Old 02 Aug 2012, 11:43
Sarteck's Avatar
Sarteck Sarteck is offline
 
Join Date: Mar 2008
I don't think it's too unreasonable to consider utilizing a method where square brackets would be acceptable in a BB Code's option, myself.

For example, enclosing the option in quotes or double-quotes to represent literal brackets rather than to-be-parsed brackets.

[QUOTE="[Sarteck]"]Lorem Ispum[/QUOTE]

This actually works, btw, already, when quote does not have a second parameter delimited by a semi-colon.

Originally Posted by [Sarteck]
Lorem Ispum
The problem only exists when the second parameter exists. E.G.



[QUOTE="[Paul M]";2353120]The fix is not to allow [ or ] in usernames.[/QUOTE][/noparse][/B]

yields
[QUOTE="[Paul M]";2353120]The fix is not to allow [ or ] in usernames.[/QUOTE]






[/QUOTE][/QUOTE][/QUOTE]Anyways, to sum it up.... I disagree with the statement that the "fix" is to not allow brackets in usernames. I think the "fix" would be to fix the problem. ;)




[SIZE=1][COLOR="Silver"]--------------- Added [DATE]1343906114[/DATE] at [TIME]1343906114[/TIME] ---------------[/COLOR][/SIZE]





[QUOTE=Sarteck;2353596]My Rambling[/QUOTE]

Ah. Seems that if the [B]entire option[/B] is enclosed with quotes, everything goes smoothly.

E.G.:
[B][noparse][QUOTE="[Sarteck];2353596"]My Rambling[/QUOTE]




Originally Posted by [Sarteck] View Post
My Rambling
:3


So, just have the Quote thingamabob enclose the stuff in quotes, yeah?

--------------- Added 02 Aug 2012 at 13:27 ---------------

---------------

Aaaaaand, problem solved on vB4 if you change the newpost_quote template.


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


I don't know if vB3 (for vB.org) would have the same solution or not.

Last edited by Sarteck; 02 Aug 2012 at 12:16. Reason: LOL, broke it. :awe:
Reply With Quote
  #8  
Old 02 Aug 2012, 15:10
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
vb.org doesnt allow such usernames, so its not an issue.
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #9  
Old 02 Aug 2012, 16:28
chefy chefy is offline
 
Join Date: Jul 2012
But could you share a fix like the one posted by Starteck for vB 3.8 users please?
Reply With Quote
  #10  
Old 02 Aug 2012, 22:58
BirdOPrey5's Avatar
BirdOPrey5 BirdOPrey5 is offline
 
Join Date: Jun 2008
Real name: Joe D.
vBulletin 3.x has a newpost_quote template too.

You could try changing it from:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

to


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

No idea if it will work.

I agree with Paul the better option is not to allow such usernames- unable to predict what else they may break in the future.
__________________
-Joe
Former vb.org Moderator. Retired.

@BirdOPrey5 | All Things BOP5 | Joe's Ultimate Off Topic
Note - I no longer making new VB mods, sorry.
Reply With Quote
  #11  
Old 03 Aug 2012, 01:45
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
Originally Posted by chefy View Post
But could you share a fix like the one posted by Starteck for vB 3.8 users please?
We cannot share what we do not have.
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #12  
Old 03 Aug 2012, 22:53
vbenhancer's Avatar
vbenhancer vbenhancer is offline
 
Join Date: Dec 2009
Real name: nexia
Originally Posted by Paul M View Post
We cannot share what we do not have.
i think he mean we find a solution for his own personal situation... basically, Shefi, you can post a unpaid request for this situation... maybe someone will get you a fix!
Reply With Quote
  #13  
Old 04 Aug 2012, 13:28
Ziki's Avatar
Ziki Ziki is offline
 
Join Date: Nov 2005
Originally Posted by Paul M View Post
We cannot share what we do not have.
What about quote notifications? I think it would be nice if every member had an option in his usercp to choose whether he wants to be notified via PM or e-mail if he's been quoted here by another member
__________________
My free mods~click here
Reply With Quote
  #14  
Old 04 Aug 2012, 15:43
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
Not sure how that is related to usernames, bbcode or my comment
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #15  
Old 04 Aug 2012, 18:53
Ziki's Avatar
Ziki Ziki is offline
 
Join Date: Nov 2005
Well since we were talking about quoting and stuff....and I didn't feel like starting a new thread if I was to get shot down right away so is it a no or a yes?
__________________
My free mods~click here
Reply With Quote
Reply



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 23:20.

Layout Options | Width: Wide Color: