[stationar]

It includes title, Site name, but not the link.

[BirdOPrey5]

Originally Posted by troyuncucom

can i use 3.8.x?

No, as VB 3.8x does not have a built in Facebook Like button this mod will not work on 3.8. I plan to release a separate mod similar to this for 3.8 but I don't have an estimate yet when that will be.

Originally Posted by stationar

It includes title, Site name, but not the link.

Please upgrade to the new version, 1.03. I have added a new option: Clean Twitter URL?- You and anyone else with a non-English forum must enable this option for Twitter Links to be created.

[oBEAVISo]

Originally Posted by BirdOPrey5

I believe that is something twitter is deciding to do on their own. If you mouse-over the link you will see it indeed has the link to the url shortener address.

Apologies, I did not notice that at all. Thankyou for the mod and thank you for the reply . nominated and installed. All buttons working as they should with tweet count turned off.

[zelnik]

Hi BOP5,

Just to clear things up with the vBSEO being compatible with this modification.

It's doesn't really work, per se. Both Twitter and G+1 display the non vbseo urls but if the end user clicks on those then vbSEO will handle that url and convert it to the SEO URL structure.

This isn't a huge problem for Twitter (even though your original Twitter integration worked fine) but for G+1 I assume this is going to be a big problem as Google will obviously only have the VBSEO urls stored on their search engine.

I'm going to try your suggest about removing the href (if memory serves me correct) but could you tell me where to look for it? in the main XML and then reinstall?

Of perhaps you could do it and post it here and we can check to see if it works?

Thanks mate.

[zelnik]

Hi BOP5,

Just to update, I've figured out how to remove the href tags from Twitter and G+1 and I can confirm they now work perfectly with VBSEO.

I've not attempted the FB stuff as it looks beyond my ability to remove those successfully.

So if you could do a vBSEO option in the next release it would be GREATLY appreciated by us users. Thanks

[BirdOPrey5]

Thanks for the update zelnik.

With Facebook, Twitter, and Digg it really doesn't matter what URL gets sent as long as the URL works- which they do.

I see what you are saying about the Google +1 though- you would want your VBSEO URL sent.

Here is the issue though...

When you first click on a post you go to a URL that looks like /showthread.php?t=1001.

But when you return to a URL via the "First unread post" link you get a URL that looks like /showthread.php?p=2001#post2001.

Plus add page numbers to the mix and you could have many different URLs for the very same page.

By forcing the "href" into the code it normalizes all of these possible URLs to just 1 consistent URL. This is essential to keep the "counts" correct and also will be sure to send someone who follows a link to the top of the page of the thread rather than some post further down the page.

I know VBSEO has nicer looking URLs than in my example above, but the issue is still the same- multiple URLs for the very same page.

I can add the VBSEO fix to the next version of this but it will be near impossible to keep the counts correct. Still it's better than nothing I guess.

[stationar]

Please upgrade to the new version, 1.03

Thanks. Fix works.

[zelnik]

Originally Posted by BirdOPrey5

By forcing the "href" into the code it normalizes all of these possible URLs to just 1 consistent URL. This is essential to keep the "counts" correct and also will be sure to send someone who follows a link to the top of the page of the thread rather than some post further down the page.

I know VBSEO has nicer looking URLs than in my example above, but the issue is still the same- multiple URLs for the very same page.

I can add the VBSEO fix to the next version of this but it will be near impossible to keep the counts correct. Still it's better than nothing I guess.

Removing the href for twitter sprung the counter into life!

I've clicked on G+1 and I get a counter for that too..

[BirdOPrey5]

Excellent news.

[BirdOPrey5]

Released version 1.05. The new option "Force Standard URL?" should be turned off for VBSEO users. This is the equivalent of doing the manual plugin edit I mentioned earlier about removing "$href" from the code.

You should probably experiment with this option whether or not you use VBSEO. It is a function of the type of friendly URL you use as well as if your forum is English language or not. Each share option has its own quirks.

[Mukashi]

Just uploaded and installed the latest version, but I seem to be having problems with the placement of the buttons. Both with the standard version and with the modified version that you have in the first post. I've attached a screenshot showing how it's appearing for us. Any reason why it would be looking like this? We're using vBSEO, and have the "Force Standard URL?" option off as instructed.

[OlijO]

Originally Posted by BirdOPrey5

First, you're welcome to everyone who has said "thank you."



No it's a conflict with the twitter button and VB4- well known. I noted this 3 times. (In the first post, in the mod instructions, and in the mod setting itself. In all 3 places I said there is a known issue and the count will probably not work with twitter. I recommend disabling the count box for twitter. I included the option to turn it on only in the event t gets fixed by either vBulletin or twitter.)



Glad to hear... I will try to program in a VBSEO Installed Yes/No option in the next version so it works either way out of the box without custom edits.




I believe that is something twitter is deciding to do on their own. If you mouse-over the link you will see it indeed has the link to the url shortener address.

Thank you for your support, and sorry for asking something who is already in the first post.
Nominated !

[BirdOPrey5]

Originally Posted by Mukashi

Just uploaded and installed the latest version, but I seem to be having problems with the placement of the buttons. Both with the standard version and with the modified version that you have in the first post. I've attached a screenshot showing how it's appearing for us. Any reason why it would be looking like this? We're using vBSEO, and have the "Force Standard URL?" option off as instructed.

That's very weird that for you your facebook button comes up last when for everyone else the facebook button comes up first. Maybe it's because you're in Australia and the seasons are reversed and the toilet water spins the other way? (just kidding.) (well a little serious.)

I have some ideas to force them into the right order but the easiest fix for now would be to add some extra spacing between the facebook button and the rest.

If you are comfortable, go to thr Admin CP -> Plugin Manager -> Edit the Plugin: More Share Options.

Find the code:

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

And replace it with:

Block Disabled:      (Update License Status)
Suspended or Unlicensed Members Cannot View Code.

Note the code added in red. That will put proper spacing between your buttons.

[Mukashi]

Now that's both interesting and weird. Adding the 3 non-breaking spaces makes no difference to the positioning, it leaves it in the same place. Though it could have perhaps been something with its interaction with another addon and tried changing the execution order, however that doesn't seem to change a thing either.

[BirdOPrey5]

If you can hold out a little longer I'm working a new version that should have vastly better positioning. It will be template based so changes, if needed, will be easier.