Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #1  
Old 11 Nov 2016, 08:29
muffel muffel is offline
 
Join Date: Mar 2007
Smile External Links to internal Links

Hello,

at the moment, we make the first steps to update from VB4 to VB5.

And in our current Forum, we had changed the class_bbcode.php in that way:

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

This change makes all external links to internal links... because the link.php just forwards the user the right website.
I have tried to make this also in the class_bbcode.php of VB5 but without success. Does anyone have also changed this into the VB5? Or do anyone know, what I have to change?
Thank you!
Reply With Quote
  #2  
Old 11 Nov 2016, 12:07
noypiscripter's Avatar
noypiscripter noypiscripter is offline
 
Join Date: Aug 2013
Are you changing it in the handle_bbcode_url() function?

Also make sure that you urlencode() the $rightlink variable in order to pass the external link properly. If the external link has querystrings, not all of them might be preserved and passed to link.php.
__________________
Glenn Vergara, an ex-vB Developer, now a vB Mod Developer

GIPHY for vB5 | AutoLinker | Video Attachments Player | New Registered Users Module | Clear System Cache Cron | DragNDrop Upload | Topic AJAX AutoUpdate | Force Read Topic
Reply With Quote
  #3  
Old 11 Nov 2016, 12:58
muffel muffel is offline
 
Join Date: Mar 2007
Yes I change it in that function - it is at the end of this function.

But when I change something, the forum still shows the old link... and I do not know why
Maybe has anyone an idea, where and what to change in detail? Thank you!

Last edited by muffel; 11 Nov 2016 at 13:32.
Reply With Quote
  #4  
Old 12 Nov 2016, 02:48
noypiscripter's Avatar
noypiscripter noypiscripter is offline
 
Join Date: Aug 2013
Try clearing system cache in AdminCP.
__________________
Glenn Vergara, an ex-vB Developer, now a vB Mod Developer

GIPHY for vB5 | AutoLinker | Video Attachments Player | New Registered Users Module | Clear System Cache Cron | DragNDrop Upload | Topic AJAX AutoUpdate | Force Read Topic
Reply With Quote
  #5  
Old 14 Nov 2016, 05:46
muffel muffel is offline
 
Join Date: Mar 2007
Thank you for your reply.

But this also does not work. The link in the forum is the same as before. Is there another place to change the link... or is it just in the class_bbcode-file?
Reply With Quote
  #6  
Old 14 Nov 2016, 22:31
noypiscripter's Avatar
noypiscripter noypiscripter is offline
 
Join Date: Aug 2013
Hi muffel,

I figured out a solution to this. I posted it on my site.

http://vbmods.rocks/forum/vbulletin-...he-destination
__________________
Glenn Vergara, an ex-vB Developer, now a vB Mod Developer

GIPHY for vB5 | AutoLinker | Video Attachments Player | New Registered Users Module | Clear System Cache Cron | DragNDrop Upload | Topic AJAX AutoUpdate | Force Read Topic
Reply With Quote
  #7  
Old 15 Nov 2016, 12:29
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Real name: Paul M
How about posting the solution here instead of a site that requires registration.
__________________
Former vBulletin.org Staff Member


Cable Forum
Please do not PM me about custom work - I no longer undertake any.
Note: I will not answer support questions via e-mail or PM - please use the relevant thread or forum.
Reply With Quote
  #8  
Old 15 Nov 2016, 21:36
noypiscripter's Avatar
noypiscripter noypiscripter is offline
 
Join Date: Aug 2013
Well, this site also requires registration.
If I posted the solution here, then guests would also need to login/register here to see the solution.

I posts solutions here and in vb.com whenever I can and you know that. But in some instances like this where I spent a good amount of time figuring out a solution, then I don't think it would be too much to ask to see the solution on my site. It's free anyway but if it was not, then I wouldn't have posted the link here.
__________________
Glenn Vergara, an ex-vB Developer, now a vB Mod Developer

GIPHY for vB5 | AutoLinker | Video Attachments Player | New Registered Users Module | Clear System Cache Cron | DragNDrop Upload | Topic AJAX AutoUpdate | Force Read Topic
Reply With Quote
  #9  
Old 15 Nov 2016, 21:55
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Real name: Mark
Originally Posted by noypiscripter View Post
Well, this site also requires registration.
If I posted the solution here, then guests would also need to login/register here to see the solution.

I posts solutions here and in vb.com whenever I can and you know that. But in some instances like this where I spent a good amount of time figuring out a solution, then I don't think it would be too much to ask to see the solution on my site. It's free anyway but if it was not, then I wouldn't have posted the link here.
But, the question was posted here, and requiring our users here to go to another site where they must register before being able to get your solution to the question posted in this thread seems like an unnecessary hurdle.
__________________
Former vBulletin.org Staff Member



Support for my products (as well as updates/new product publishing) has been moved to MHB - vBulletin Products and TAZ - Add-ons
Reply With Quote
  #10  
Old 16 Nov 2016, 07:16
shimei shimei is offline
 
Join Date: Feb 2015
Originally Posted by MarkFL View Post
But, the question was posted here, and requiring our users here to go to another site where they must register before being able to get your solution to the question posted in this thread seems like an unnecessary hurdle.
For SEO reasons I can understand it. If I were for example, to post a mod and instructions here and the same on my own site there would be duplicate content. I would think there would be a chance that the mod would be published here before my own site on google, especially considering the page ranking of vb.org.

Regarding Glenn's site, to be honest it is making this site obsolete for Vbulletin 5 users. The staff here at this site kills Vbulletin 5 in my opinion. Nobody here helps out Vb 5 users (hyperbole), that's why so many people duplicate their post asking here and then at Vbulletin.com.

They should just archive this site from a Vbulletin 5 perspective. It is really only a good site if someone has vb 3 or 4 questions. The staff not answering or being capable to help with Vb 5 gives people the impression there is not much custom support for the product. I'd love to see support from here, but if I have a question or need help with Vb 5, especially for mods this is the last place I usually turn to.

Just sharing my opinion, hope nobody is offended.

Enjoy,
William

Last edited by shimei; 16 Nov 2016 at 07:21.
Reply With Quote
  #11  
Old 17 Nov 2016, 18:16
sticky sticky is offline
 
Join Date: Sep 2003
Originally Posted by Paul M View Post
How about posting the solution here instead of a site that requires registration.
Does this site require registration? Solid logic Paul.
Reply With Quote
  #12  
Old 17 Nov 2016, 18:27
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Real name: Mark
Originally Posted by sticky View Post
Does this site require registration? Solid logic Paul.
The question was posted on this site, so registration here isn't really relevant, since anyone posting here is already registered here. The mild objection I have, is for a user who posts a question here to be directed to a site that requires registration there in order to read the posted solution.
__________________
Former vBulletin.org Staff Member



Support for my products (as well as updates/new product publishing) has been moved to MHB - vBulletin Products and TAZ - Add-ons
Reply With Quote
Reply


Tags
bbcode, external link, website


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 15:15.

Layout Options | Width: Wide Color: