Register Members List Search Today's Posts Mark Forums Read

Reply
 
Thread Tools
  #16  
Old 01 Mar 2012, 00:03
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
Originally Posted by rpgamersnet View Post
I guess my question was just if the other part that was added is needed, the looping replace function that removes SQL words from comments (but also removes good data). It is near the bottom of the 2.7.2 arcade.php ... needed or just playing it safe?
what good data is it removing ?
Reply With Quote
  #17  
Old 01 Mar 2012, 13:14
rpgamersnet's Avatar
rpgamersnet rpgamersnet is offline
 
Join Date: Jul 2004
Originally Posted by Hippy View Post
what good data is it removing ?
If you refer to this post: http://www.vbulletin.org/forum/showp...91&postcount=5

The code I am asking about is the loop that removes all the SQL keywords from the comments. Most I'm sure won't come across in normal comments, but filtering out parts like "or" and "and" are going to catch and mess up standard comments, as given in the example on that post.

"I got the high score!" becomes "I got the high sce!"

"Got a great hand on the last round!" -> "Got a great h on the last round"

Some basic words will get filtered as well, not just the bad SQL data, which is why I suggested that maybe this fix is not the best solution. Code I am questioning is quoted here:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Some recent threads have started to appear complaining of errors appearing, this new code is also the source of those new problems; the new recursive_str_ireplace loop to replace these parts of the comment field.... and any other field being filtered by the ibp_cleansql function.

Last edited by rpgamersnet; 01 Mar 2012 at 13:19.
Reply With Quote
  #18  
Old 01 Mar 2012, 21:32
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
thanks .. do this http://www.vbulletin.org/forum/showp...3&postcount=13
and pull the new code added out..
this will do the job.. but does not work on all servers..

stangger5 is going to work this out ..
I think code it to the way vb does it ..
but this is not set in stone ATM.. just a twinkle in the sky
Reply With Quote
  #19  
Old 02 Mar 2012, 02:11
rpgamersnet's Avatar
rpgamersnet rpgamersnet is offline
 
Join Date: Jul 2004
Originally Posted by Hippy View Post
thanks .. do this http://www.vbulletin.org/forum/showp...3&postcount=13
and pull the new code added out..
this will do the job.. but does not work on all servers..

stangger5 is going to work this out ..
I think code it to the way vb does it ..
but this is not set in stone ATM.. just a twinkle in the sky
Yep I already made the change he noted If I knew more about the inner workings of VB I'd offer to try to be of more help, but I have never messed with mods much myself. Look forward to any fixes that might arise

Thanks to everyone for helping out! Great community this mod has.
Reply With Quote
  #20  
Old 02 Mar 2012, 02:30
Hippy's Avatar
Hippy Hippy is offline
 
Join Date: Dec 2001
stannger5 can explain more about it but this is what I use since the other will kill wanted stuff...
Reply With Quote
  #21  
Old 08 Mar 2012, 20:40
g7jgq g7jgq is offline
 
Join Date: Apr 2006
Originally Posted by rpgamersnet View Post
If you refer to this post: http://www.vbulletin.org/forum/showp...91&postcount=5

The code I am asking about is the loop that removes all the SQL keywords from the comments. Most I'm sure won't come across in normal comments, but filtering out parts like "or" and "and" are going to catch and mess up standard comments, as given in the example on that post.

"I got the high score!" becomes "I got the high sce!"

"Got a great hand on the last round!" -> "Got a great h on the last round"

Some basic words will get filtered as well, not just the bad SQL data, which is why I suggested that maybe this fix is not the best solution. Code I am questioning is quoted here:


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Some recent threads have started to appear complaining of errors appearing, this new code is also the source of those new problems; the new recursive_str_ireplace loop to replace these parts of the comment field.... and any other field being filtered by the ibp_cleansql function.
As I posted in another thread, before searching !!!!!!!!!! its also stripping the words out of game names which I suspect will break a lot of games.

When it gets the game name from the posted data


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

A game such as wordrace will end up as wdrace

For now I have just modified the replacement list as follows, its NOT a good fix but at least all of the games will submit scores now :-)


Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

I know that won't solve the problem in comments but we don't really use comments. I am going to look at an alternative fix for this over the weekend

Cheers

Alex

Last edited by g7jgq; 08 Mar 2012 at 20:47.
Reply With Quote
  #22  
Old 09 Mar 2012, 02:13
stangger5's Avatar
stangger5 stangger5 is offline
 
Join Date: Jan 2005
Originally Posted by g7jgq View Post

I know that won't solve the problem in comments but we don't really use comments. I am going to look at an alternative fix for this over the weekend

Cheers

Alex
Give this a try : http://www.vbulletin.org/forum/showp...04&postcount=6
__________________
vb ibProArcade: Download Game, Game Challenge, Report Game, Daily Game Systems.
40,000+ Flash and HTML5 Games,, and more can be found at: next-level-arcade.com
Reply With Quote
  #23  
Old 09 Mar 2012, 13:04
g7jgq g7jgq is offline
 
Join Date: Apr 2006
Originally Posted by stangger5 View Post
Thanks for that.

Looking at that code it will do the same thing, the problem is you cannot get rid of SQL command by simply doing replaces in the posted data.

Cheers

Alex
Reply With Quote
Reply

Similar Threads
Thread Thread Starter Forum Replies Last Post
Mini Mods Fix overlapping blog comments images shahz vBulletin 4.x Template Modifications 2 04 Nov 2010 04:17
BB Code Enhancements Image with Alternate Text BB Code mikkitine vBulletin 3.7 Add-ons 7 02 Jul 2008 02:29



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


New To Site? Need Help?

All times are GMT. The time now is 09:39.

Layout Options | Width: Wide Color: