Register Members List Search Today's Posts Mark Forums Read

Reply
 
Mod Options
Patched Flash Uploader to Fix Known Exploits Details »
Patched Flash Uploader to Fix Known Exploits
Mod Version: 2.00, by alexm (Coder) alexm is offline
Developer Last Online: Apr 2019 I like it Show Printable Version Email this Page

vB Version: 4.x.x Rating: (33 votes - 4.88 average) Installs: 203
Released: 14 Jan 2014 Last Update: Never Downloads: 840
Supported Code Changes Additional Files  

UPDATE Dec 2014: 4.2.2 PL2, 4.2.2 PL3 and 4.2.3 core download packages from vBulletin now include this patched version of uploader.swf as standard.

This is a patched version of YUI 2.9.0 uploader.swf as used by vBulletin 4.x for managing multiple file uploads.

An exploit was found in the flash uploader (uploader.swf) file supplied with vBulletin 4.x. This file is part of the Yahoo YUI 2 Library which is end of life and Yahoo have stated that they will not be fixing it. Yahoo recommends that the file is removed as the flash uploader has been deprecated.

vBulletin's recommended fix is to replace the file with an empty file of the same name. If you do this, however, and rely solely on the Ajax uploader you will not be able to select multiple files without further modifications.

This modification is a recompiled version of uploader.swf with the above exploit fixed. An additional potential exploit has also been fixed by disabling a parameter not used by vBulletin.

The YUI source used is provided freely by Yahoo to whom I give full credit.


1) Installation

a) Extract uploader.swf from the .zip file and replace your existing file here:

<forum_root>/clientscript/yui/uploader/assets/uploader.swf

b) Make sure the flash uploader is enabled in the Admin Control Panel

Options -> Message Attachment Options -> Asset Manager - Enable -> Select "Yes, Flash Upload by Default"

c) Make sure you are NOT using remote YUI

vBulletin Options -> Server Settings and Optimization Options

Use Remote YUI set to None

d) You may also need to clear your browser cache and/or vBulletin cache (Maintenance ->Clear system cache) if you have performed the above steps correctly but clicking the Upload button still does nothing.



2) Changes

11th January 2014

The parameter 'allowedDomain' has been sanitised with a REGEX to prevent malicious javascript being passed in a query string.


11th January 2014 v2

Many thanks to FranzBanz (http://www.vbulletin.com/forum/member/449383-franzbanz) for his suggestions
  • finding another exploit (using another parameter). Exploit fixed by setting the parameter (not used by vBulletin) to null.
  • '-' Character added to allowed characters in allowedDomain


Non-Flash Alternative
Please note that if you would rather avoid using flash altogether an alternative Mod has been released by BirdOPrey5, although there are some compromises/limitations with IE10+.

Asset Manager / Image Upload Fix to upload multiple files like the Flash uploader


DISCLAIMER
I am not a flash developer, I am just another vBulletin customer trying to keep his members happy!
This file is provided free of charge for the benefit of the vBulletin community. You use it at your own risk!


Copyright 2013 Yahoo! Inc. All rights reserved.
Redistribution and use of this software in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

Neither the name of Yahoo! Inc. nor the names of YUI's contributors may be used to endorse or promote products derived from this software without specific prior written permission of Yahoo! Inc.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Download Now

Only licensed members can download files, Click Here for more information.

Show Your Support

  • To receive notifications regarding updates -> Click to Mark as Installed.
  • This modification may not be copied, reproduced or published elsewhere without author's permission.
Comments
  #2  
Old 14 Jan 2014, 18:21
ckgb ckgb is offline
 
Join Date: Oct 2007
Thank you very much!!!
Reply With Quote
  #3  
Old 14 Jan 2014, 20:07
Diesel, Diesel, is offline
 
Join Date: May 2008
Thanks for the Patch.
__________________
Join My Community
Reply With Quote
  #4  
Old 14 Jan 2014, 20:11
tester559 tester559 is offline
 
Join Date: Feb 2004
Thank you I appreciate your time in fixing this issue

Stuart
Reply With Quote
  #5  
Old 14 Jan 2014, 20:15
Mark.B Mark.B is offline
 
Join Date: Feb 2004
Thanks very much for your work on this, it is much appreciated by many of us who miss the Flash functionality.

I'll get this installed on my own site in the next few days.
Reply With Quote
  #6  
Old 14 Jan 2014, 23:39
BirdOPrey5's Avatar
BirdOPrey5 BirdOPrey5 is offline
 
Join Date: Jun 2008
Real name: Joe D.
Thank You.
__________________
-Joe
Former vBulletin.org Staff Member

(@BirdOPrey5) Former vb.org Moderator. Fighting for a free & independent vb.org.
BirdOPrey5.com - Exclusive VB Mods! (Formerly Qapla.com) | Joe's Ultimate Off Topic
Note - I do not read my PMs often, do not expect quick replies.
Reply With Quote
  #7  
Old 14 Jan 2014, 23:58
bzcomputers's Avatar
bzcomputers bzcomputers is offline
 
Join Date: Apr 2012
I'm always worried about when my vb4 will inevitably be forced to retire and in turn force me to move on to something else due to issues like this that arise.

Luckily there are still some great coders around supporting it. Unfortunately fewer and fewer these days though

Thanks for the fix.
Reply With Quote
  #8  
Old 15 Jan 2014, 03:41
Hostboard's Avatar
Hostboard Hostboard is offline
 
Join Date: May 2002
Real name: Steven
Thank you 100x over.
Reply With Quote
  #9  
Old 15 Jan 2014, 03:52
puertoblack2003's Avatar
puertoblack2003 puertoblack2003 is offline
 
Join Date: Aug 2005
thank you for you time and the patch.
__________________
Android Custom Creations
Reply With Quote
  #10  
Old 15 Jan 2014, 07:50
hugh_ hugh_ is offline
 
Join Date: Mar 2005
Great work, thank you!
Reply With Quote
  #11  
Old 15 Jan 2014, 09:39
ezak ezak is offline
 
Join Date: Nov 2004
thank you installed
Reply With Quote
  #12  
Old 15 Jan 2014, 14:08
Thangvip9x Thangvip9x is offline
 
Join Date: Apr 2012
Real name: Thang
Thank you
Reply With Quote
  #13  
Old 15 Jan 2014, 15:27
tommyxv tommyxv is offline
 
Join Date: Feb 2005
Thank very much!
__________________
Reply With Quote
  #14  
Old 15 Jan 2014, 19:10
Trevor Matthews Trevor Matthews is offline
 
Join Date: Oct 2010
Hi
Excellent work and has saved many of us from lots of trouble on our forums.
Many thanks.
Reply With Quote
  #15  
Old 15 Jan 2014, 19:52
miszko miszko is offline
 
Join Date: May 2011
Real name: Michal
Thanks man! I also nominated this mod to MOTM.
Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Mod Options

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 14:01.

Layout Options | Width: Wide Color: