Register Members List Search Today's Posts Mark Forums Read

Reply
 
Mod Options
Local links to titles Details »
Local links to titles
Mod Version: 1.00, by JohnWoo (Member) JohnWoo is offline
Developer Last Online: Apr 2014 I like it Show Printable Version Email this Page

This modification is in the archives.
vB Version: 3.0.0 Rating: (0 vote - 0 average) Installs: 9
Released: 04 Sep 2004 Last Update: Never Downloads: 17
Not Supported  

Hello!

Not sure again - may be something like it exist already, but I was not able to find
That small hack adds only one feature. Links to local board posts, threads and forums will appear on that threads and post titles. For example link text for
http://www.vbulletin.org/forum/showt...2&goto=newpost
will be turned to "Fulltext boolean search v.2.2 for vB" and on http://www.vbulletin.org/forum/forumdisplay.php?f=32 - to "Code Modifications vB3".
But please be careful - it adds additional DB request for each local link on page.

Fixes:
v 1.1

- fixed links to multiply pages threads with pp= in url

Download Now

Only licensed members can download files, Click Here for more information.

Show Your Support

  • To receive notifications regarding updates -> Click to Mark as Installed.
  • If you like this modification support the author by donating.
  • This modification may not be copied, reproduced or published elsewhere without author's permission.
Similar Mod
Mod Developer Type Replies Last Post
Mini Mods Same Window For Local Links Viper007Bond vBulletin 3.6 Add-ons 54 02 Nov 2011 16:59
Replace Local Links With Titles vietkieu_cz vBulletin 3.5 Add-ons 8 07 Dec 2008 04:52

Comments
  #2  
Old 04 Sep 2004, 14:03
nexialys
Guest
 
i always dreamed of this, but never took a look at the code.. lol

btw, GREAT!
Reply With Quote
  #3  
Old 04 Sep 2004, 14:32
BarHopper BarHopper is offline
 
Join Date: Mar 2003
Wow,l this is great,. Thanks
Reply With Quote
  #4  
Old 04 Sep 2004, 18:44
Dean C's Avatar
Dean C Dean C is offline
 
Join Date: Jan 2002
Real name: Dean Clatworthy
Thankyou for sharing your work with the community
__________________
Dean Clatworthy - Web Developer/Designer
Reply With Quote
  #5  
Old 04 Sep 2004, 19:31
ranger2kxlt ranger2kxlt is offline
 
Join Date: Jan 2003
Real name: Justin
I'm lost as to what this does? Can someone explain a bit more?

Thanks
Reply With Quote
  #6  
Old 04 Sep 2004, 19:37
roundhost roundhost is offline
 
Join Date: Aug 2004
Real name: Sir Frederick The Great!
wicked cool!
Reply With Quote
  #7  
Old 04 Sep 2004, 22:36
Mike11212 Mike11212 is offline
 
Join Date: Jul 2002
Originally Posted by ranger2kxlt
I'm lost as to what this does? Can someone explain a bit more?

Thanks
Basically when someone post a link to a thread the link will turn into a text link. The text being the threads title.
Reply With Quote
  #8  
Old 05 Sep 2004, 06:39
ChurchMedia's Avatar
ChurchMedia ChurchMedia is offline
 
Join Date: Dec 2002
Real name: Tim Eason
Nice! *installs

Small bug that I'm sure you can fix. If you use a link that came from (for instance) a page 3 of a thread, you get a "Post not found". This link won't work:

I think it's because of the &page=3&pp=15.

I'm sure you can fix it up

Last edited by ChurchMedia; 05 Sep 2004 at 06:55.
Reply With Quote
  #9  
Old 05 Sep 2004, 06:55
JohnWoo's Avatar
JohnWoo JohnWoo is offline
 
Join Date: Jan 2002
yes.. sorry - it is because of pp=15
to fix it just replace

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

with

Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.


i'll upload new zip in few minutes

Last edited by JohnWoo; 05 Sep 2004 at 06:59.
Reply With Quote
  #10  
Old 05 Sep 2004, 07:14
ChurchMedia's Avatar
ChurchMedia ChurchMedia is offline
 
Join Date: Dec 2002
Real name: Tim Eason
Perfect! Works great now.

Thanks!!!
Reply With Quote
  #11  
Old 05 Sep 2004, 13:45
CarCdr CarCdr is offline
 
Join Date: Apr 2004
John,

A few comments from only reading the code.

* The implementation should never return an error message instead of a link. If I post a link and you find that I do not have access or you could not find the post, the code should fall through to behave as it would without this mod -- i.e., just leave the link alone.

* Are you replacing all instances of "forumid", "threadid", and "postid" with "f", "t", and "p"?
This would mangle a mod with those strings anywhere else in the URL, like "/my_mod_forumid.php?p=1234".

* Access to a thread/post should be CANVIEWOTHERS if one is not the author.

* You seem to be checking a URL for "p=" first and then overwriting the results if "t=" is found in the same URL. Perhaps you are missing an 'else'.

* You could think about using the post title (p=1234 case) when it is set (i.e., not the thread title).

* "showpost.php" case would be useful and is very similar to "showthread.php" case.



Also, this may give you some other ideas:
http://www.vbulletin.org/forum/showthread.php?t=68398

Cheers

Last edited by CarCdr; 05 Sep 2004 at 15:48.
Reply With Quote
  #12  
Old 05 Sep 2004, 15:29
JohnWoo's Avatar
JohnWoo JohnWoo is offline
 
Join Date: Jan 2002
Completely agree with everything - it was just fast "weekend idea" and far from perfect
May be except "post title" - i still think that thread title will always give better description for link.
I'll make and upload v1.2 as soon as I'll have free time again But one question - sorry
I never was vb3 administrator and have no working vb3 near, so can you please give example url with both "p=" and "t=" variables?
Reply With Quote
  #13  
Old 05 Sep 2004, 15:54
CarCdr CarCdr is offline
 
Join Date: Apr 2004
t= and p= in same URL
I was mistaken. Although they can both appear in a showthread URL, the t= will override.

Nevertheless, you likely still need an else between the t= and p= code.

Also, I would guess that most people likely want local links to open in the same window. A config option would be a good idea here.
Reply With Quote
  #14  
Old 05 Sep 2004, 20:37
ChurchMedia's Avatar
ChurchMedia ChurchMedia is offline
 
Join Date: Dec 2002
Real name: Tim Eason
Sorry . I found another bug. When parsing a URL to a member user, it creates a link like: member.php?u=1234 and drops out the name of the user. You can see an example here: http://www.churchmedia.net/community...ead.php?t=5100

Edit: I uninstalled the hack and resaved the post above and it fixed it, so it doesn't show the problem anymore. Just try this in a post and see what you get:
Block Disabled:      (Update License Status)  
Suspended or Unlicensed Members Cannot View Code.

Maybe you need some definition for u=xxxx?

Also, I agree that you should make the url just show up as-is instead of giving a "post not found" error. That would take care of potential problems.

Great concept

Last edited by ChurchMedia; 05 Sep 2004 at 20:48.
Reply With Quote
  #15  
Old 06 Sep 2004, 09:42
JohnWoo's Avatar
JohnWoo JohnWoo is offline
 
Join Date: Jan 2002
i'll add everything and fix exerything tomorrow
sorry - too busy today...
Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Mod Options

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


New To Site? Need Help?

All times are GMT. The time now is 11:04.

Layout Options | Width: Wide Color: